Batch file - If statement and goto error

Question

Anything put into this part of this batch file automatically goes to :yes, regardless of whether the string is contained in MRSVANDERTRAMP.txt or not.

:enterverb
set /p id=Enter Verb: 

findstr /m %id% MRSVANDERTRAMP.txt
if %errorlevel%==0 (
goto :yes 
) else (
goto :no
)

:no
echo Verb does not take etre in the Perfect Tense. 
pause
goto :option0

:yes
echo Verb is a MRSVANDERTRAMP verb and takes etre in the Perfect Tense.
pause

http://stackoverflow.com/questions/8530976/how-to-conditionally-take-action-if-findstr-fails-to-find-a-string — Adam Burry, Sep 10 '13 at 19:04
Is there `:option0` tag ? Because if not the code will always go trhough the yes part. — npocmaka, Sep 10 '13 at 19:47
Yes, that is lower down (and not shown in this piece of the code). — Max Hallam, Sep 10 '13 at 20:07
why use `goto` when you can put the yes and no block in the if/else blocks already? — phuclv, Mar 11 '18 at 02:15

Immortal Fire · Answer 1 · 2013-09-10T20:32:18.107

1

I came up with a similar code to test it, and it works.

@echo off
@title TEST

:main
set /p word=Write a word: 

findstr /M %word% words.txt

if "%errorlevel%" == "0" ( echo FOUND ) else ( echo NOT FOUND )
pause>nul
cls && goto main

Maybe there's a problem with the IF statement.. Try using

if "%errorlevel%" == "0"

insead of

if %errorlevel%==0

edited Sep 10 '13 at 20:32

answered Sep 10 '13 at 20:25

Immortal Fire

57
7

This does seem to work, and fixes another problem as well. Thanks! – Max Hallam Sep 10 '13 at 20:44

score 0 · Answer 2 · answered Sep 10 '13 at 22:03

This works fine. You might like to surround "%id%" in double quotes as shown, to protect against some poison characters though.

@echo off

echo one>MRSVANDERTRAMP.txt
echo two>>MRSVANDERTRAMP.txt


:enterverb
set /p id=Enter Verb: 

findstr /m %id% MRSVANDERTRAMP.txt
if %errorlevel%==0 (
goto :yes 
) else (
goto :no
)

:no
echo Verb does not take etre in the Perfect Tense. 
pause
goto :option0

:yes
echo Verb is a MRSVANDERTRAMP verb and takes etre in the Perfect Tense.
pause

:option0
echo done
pause

score 0 · Answer 3 · edited Nov 22 '14 at 17:06

0

Dude try this

enterverb

set /p id=Enter Verb: 
findstr /m %id% MRSVANDERTRAMP.txt

set a=0

if %errorlevel%== %a% (
goto :yes 
) else (
goto :no
)

:no
echo Verb does not take etre in the Perfect Tense. 
pause
goto :option0

:yes
echo Verb is a MRSVANDERTRAMP verb and takes etre in the Perfect Tense.

edited Nov 22 '14 at 17:06

Stephan

53,940
10
58
91

answered Nov 22 '14 at 16:56

NecroBit

1
1

score 0 · Answer 4 · edited Nov 22 '14 at 18:12

0

I had the same problem in this code:

@echo off

ping www.google.com
if %errorlevel%== 0 (
goto :ok
) else (
go to :fail
)

:ok
echo ok
pause

:fail
echo fail
pause

Always go to :ok but with a set off var=0 my problem is solved and my code runs.

@echo off
ping www.google.com
set a=0
if %errorlevel%== %a% (
goto :ok
) else (
goto :fail
)

:ok
echo ok
pause


:fail
echo fail
pause

edited Nov 22 '14 at 18:12

Nima Soroush

12,242
4
52
53

answered Nov 22 '14 at 17:46

NecroBit

1
1

Batch file - If statement and goto error

4 Answers4