Static final member variables vs. get methods

Question

I have a class with all the configuration from a property file.

My first solution is this:

public class Config {

    public static final int disc;

    static {

        // Read property file and set properties

        disc = 5;
    }
}

Reading the information in this way:

System.out.println(Config.disc);

The second solution is:

public class Config {

    private int disc;

    public void Config() {

        // Read property file and set properties

        disc = 5;
    }

    public int getDisc() {
        return this.disc;
    }
}

Reading in that way:

System.out.println(new Config().getDisc());

What's the best way and why? What the advantages and disadvantages?

It rather looks like your trying to make a [Singleton](http://en.wikipedia.org/wiki/Singleton_pattern) (in which case a Singleton would be the best way). — Bernhard Barker, Sep 04 '13 at 09:56

score 2 · Answer 1 · answered Sep 04 '13 at 10:00

The answer depends on the meaning of disc:

If disc represents a constant, essentially giving a name to a numeric value, than a public final field is better
If disc represents a value that could change as the result of user's actions (i.e. if it is part of configuration) then a private variable with a getter is preferable.

The second approach gives you more flexibility, should you decide to refactor your class in the future: it lets you initialize the private disc at a later time, or replace it with some other way of obtaining a value, e.g. by computing it from other values, or reading from another object.

Prasad Kharkar · Answer 2 · 2013-09-04T10:00:29.760

using getDisc() you can have one disc variable per object while static disc is shared across all the instances.

If you have different disc value for every instance of class, then go for second approach.
If you have same value which needs to be shared across all the instances of the class, then use the first approach

By they way, you cannot do System.out.println(Config.getDisc());. You can't call a non-static method using class name

score 1 · Answer 3 · answered Sep 04 '13 at 09:56

1

What about: public static final int DISC = 5; Then you can use Config.DISC to access your config value.

answered Sep 04 '13 at 09:56

mithrandir

738
1
6
17

score 1 · Answer 4 · answered Sep 04 '13 at 09:56

System.out.println(Config.getDisc());

This is wrong. You can't call a non-static method with class name. You must create an object as following:

Config cfg = new Config();
System.out.println(cfg.getDisc());

Now, In your first case all the instances will share same copy of disc. so, if it's not a constant, go for 2nd case.

score 0 · Answer 5 · answered Sep 04 '13 at 10:05

What you want in this case is really

public static final int DISC = 5;

System.out.println(Config.DISC);

(Note that members like these are conventionally always written in capticals).

Your first solution has an error in it. It won't compile because you try to set a final field multiple times. Each time you create a new Config(), you will assign a value to disc, but since it is final that won't work. What you probably wanted to suggest was to put it in the static constructor:

public class Config
{
    public static final int DISC;
    static
    {
        DISC = 5;
    }
}

However, I do not recommend it, because is is totaly find to do it the first way I wrote and is much easier as well.

Your second solution has an error in it. It won't compile because you can't access the non-static method from a static context. This means that you first will have to create an instance of Config, before you can call the getDisc() method. The better solution in this case is to declare the method as static.

Static final member variables vs. get methods

5 Answers5