PHPMD avoid static access to parent

Question

Is there a way to avoid the parent:: static accessor in PHP classes, or is this one of those times to use @SuppressWarnings(StaticAccess)?

On the same lines, it seems like this StaticAccess warning is popping in suspicious places. Exception handling, for instance - when I throw new Exception(...), PHPMD complains about static access. But...there's not really another way to do it (that I've found) so I've got more warnings suppressors than I'd like. Is this normal?

EDIT

As requested, here's an example - it's pretty straightforward:

class aaa {
    private $someReasonForAnException = true;

    public function __construct() {
        echo 'AAA<br>';
        if ($this->someReasonForAnException) {
            throw new Exception("Something happened that's worth noticing!");
        }
    }
}

class bbb extends aaa {    
    public function __construct() {
        echo 'BBB<br>';
        parent::__construct();
    }
}

$BBB = new bbb();

PHPMD will report two errors with the above: a StaticAccess error on the Exception, and a StaticAccess error on the parent::__construct() call.

To avoid that, I've got to notate both classes with @SuppressWarnings , which seems clunky, and also won't show "real" static access problems.

@HenriqueBarcelos - thanks for taking a look, there's an example. — Ben, Sep 04 '13 at 02:16
You're not making any static calls; I would report this as a bug. — Ja͢ck, Sep 04 '13 at 02:34
Fwiw, I've made a pull request [here](https://github.com/phpmd/phpmd/pull/104) :) — Ja͢ck, Sep 04 '13 at 03:25

score 5 · Answer 1 · edited Jul 08 '15 at 19:42

5

A simple and sustainable solution might be to

override the Clean Code ruleset
set the "exceptions" property on the StaticAccess rule to include self and parent:

edited Jul 08 '15 at 19:42

Félix Adriyel Gagnon-Grenier

8,422
10
52
65

answered Jul 08 '15 at 14:24

Dane Powell

621
7
13

score 4 · Accepted Answer · edited Jun 20 '20 at 09:12

4

There is no other way to reference parent's method implementation on PHP. There is nothing wrong with your code, PHPMD is drunk. The only problem you'd have with static access is because PHP allows you to call an instance method as a static method if it does not reference $this variable, but there is no point on doing so. You can ignore this kind of warning.

Edit:

If you have something like this:

class Foo {
    public function bar() {
        echo 'bar';
    }
}

PHP will allow you to do:

Foo::bar(); // works

But if you have this:

class Foo {
    private $bar = 'bar';
    public function bar() {
        echo $this->bar;
    }
}

Foo::bar(); // fatal error

edited Jun 20 '20 at 09:12

Community

1
1

answered Sep 04 '13 at 02:21

Henrique Barcelos

7,670
1
41
66

Good news then, I suppose. Could you explain `PHP allows you to call an instance method as a static method if it does not reference $this variable, but there is no point on doing so.` a little differently? I don't quite get your point. Do you mean, PHP will call the instantiation as a static method, by default? – Ben Sep 04 '13 at 02:25

score 0 · Answer 3 · answered May 25 '14 at 15:30

0

Because I use a lot of self:: for constants, change phpmd code to accept self:: and parent::.

In the program PHP/PMD/Rule/CleanCode/StaticAccess.php at line 36, change to:

if ($this->isReferenceInParameter($reference)
    || $reference->getImage() === 'self' 
    || $reference->getImage() === 'parent' 
    ) {
    continue;
}

answered May 25 '14 at 15:30

Alejandro Salamanca Mazuelo

1,173
15
21

Great, but what about when you have to update PHPMD? ;) – Ben May 26 '14 at 14:37

PHPMD avoid static access to parent

3 Answers3

Edit: