Warning: Division by zero PHP check

Question

I am using symfony 1.1 to read an API and store the values in DB

if(($xmlArray->{'MDD'} == 0) || ($xmlArray->{'MDD'} == '0') ){  
       $autoStraObj->setRisk(' - ');
    }else{
       $autoStraObj->setRisk(round(($xmlArray->{'Pips'} / $xmlArray->{'MDD'}), 10));
    }

For Some Records, the above code results with

Warning: Division by zero in.... Not sure, that is the issue here

GautamD31 · Answer 1 · 2013-08-21T05:15:47.817

1

First check $xmlArray->{'MDD'} is zero or not.If it is zero for some records then it will give you this error.

if(($xmlArray->{'MDD'} != 0) && ($xmlArray->{'MDD'} != ''))
{
   $autoStraObj->setRisk(round(($xmlArray->{'Pips'} / $xmlArray->{'MDD'}), 10));
}

Or simply

if(!empty( $xmlArray->{'MDD'}) ) {
   $autoStraObj->setRisk(round(($xmlArray->{'Pips'} / $xmlArray->{'MDD'}), 10));
}

Or as cHao said try like

if (+$xmlArray->{'MDD'} != 0) {
   $autoStraObj->setRisk(round(($xmlArray->{'Pips'} / $xmlArray->{'MDD'}), 10));
}

edited Aug 21 '13 at 05:15

answered Aug 21 '13 at 05:07

GautamD31

28,552
10
64
85

see `if(($xmlArray->{'MDD'} == 0) || ($xmlArray->{'MDD'} == '0') ){ ` – Dipesh Parmar Aug 21 '13 at 05:09
Note, `empty($xmlArray->{'MDD'})` is false if the value is the string '0.0'. You might do better to just say `if (+$xmlArray->{'MDD'} != 0)`. – cHao Aug 21 '13 at 05:14
Then he need to type casting with int – GautamD31 Aug 21 '13 at 05:15

score 0 · Answer 2 · answered Aug 21 '13 at 05:07

0

Because for some records $xmlArray->{'MDD'} equals zero.

To avoid this - first check if there is a 0 and do not divide, just show "0" instead.

answered Aug 21 '13 at 05:07

Paul Denisevich

2,329
14
19

That appears to be exactly what the script is doing, though. – cHao Aug 21 '13 at 05:09

Parixit · Answer 3 · 2013-08-21T05:23:07.980

0

Please check for


if(empty($xmlArray->{'MDD'})){  
       $autoStraObj->setRisk(' - ');
    }else{
       $autoStraObj->setRisk(round(($xmlArray->{'Pips'} / $xmlArray->{'MDD'}), 10));
    }

edited Aug 21 '13 at 05:23

answered Aug 21 '13 at 05:10

Parixit

3,829
3
37
61

Warning: Division by zero PHP check

3 Answers3