Display only properties with values in TimeSpan Display Template

Question

I need to create a display template in ASP.NET MVC 3 that will display a Timespan, showing only the properties with values set. Here are some examples to show what I mean:

Timespan: 1 day, 2 hours, 3 minutes
Required display: "1 day, 2 hours, 3 minutes"

Timespan: 0 days, 2 hours, 1 minute
Required display: "2 hours, 1 minute"

Timespan: 0 days, 5 hours, 0 minutes
Required display: "5 hours"

So as you can see, I need to show only the non-zero values; but I don't know how... apart from an inelegant solution with many if statements. I want to find a better way.

Here is my current code:

@model TimeSpan

@if (Model.Days > 0)
{
    @Model.Days if (Model.Days > 1)
                {<text>days</text>}
                else
                { <text>day</text>}
}

@if (Model.Hours > 0)
{
    if (Model.Days > 0)
    {
        @:, 
    }
    @Model.Hours if (Model.Hours > 1)
                 {<text>hours</text>}
                 else
                 { <text>hour</text>}
}

@if (Model.Minutes > 0)
{
    if (Model.Days > 0 || Model.Hours > 0)
    {
        @:, 
    }
    @Model.Minutes if (Model.Minutes > 1)
                   {<text>minutes</text>}
                   else
                   { <text>minute</text>}
}

Why not extract it out into a utility or helper method which you can then just call? — Lloyd, Aug 19 '13 at 10:15
Yes I can also extract it as an extension method, but what am asking for is help with the logic / code structure. — Kev, Aug 19 '13 at 10:20
I think Peter has an answer similiar to your problem at his question: http://stackoverflow.com/questions/842057/how-do-i-convert-a-timespan-to-a-formatted-string — Marco, Aug 19 '13 at 10:26

Raphaël Althaus · Accepted Answer · 2013-08-19T10:56:43.427

You might refactor a bit (untested, not sure if @functions will work in a template file, but... why wouldn't it ?)

@model TimeSpan

@functions{
    public string FormatElement(int value, string text){
        if (value == 0) return string.Empty;
        if (value > 1) text +="s";
        return string.Format("{0} {1}", value, text);
    }
}

@string.Join(", ",  new[]{
                        FormatElement(Model.Days, "day"), 
                        FormatElement(Model.Hours, "hour"), 
                        FormatElement(Model.Minutes, "minute")
                    }
                   .Where(m => m != string.Empty));

score 0 · Answer 2 · edited May 23 '17 at 12:05

0

As @Serv commented this was answered at How do I convert a TimeSpan to a formatted string? by Peter.

Please go there to see his solution.

edited May 23 '17 at 12:05

Community

1
1

answered Aug 21 '13 at 10:57

Kev

2,656
3
39
63

Display only properties with values in TimeSpan Display Template

2 Answers2