Mocha failed assertion causing timeout

Question

I'm getting started with mocha testing framework with NodeJS. Success assertions working fine but if the assertion fails, my test timeouts. For asserting I've tried Should and Expect. For example (async code)

  it('should create new user', function(done){
    userService.create(user).then(function(model){
      expect(model.id).to.be(1); //created user ID
      done();
    }, done)
  });

Here the if model id is not 1 then the test timesout instead of reporting failed assertion. I'm sure I'm doing something wrong. Appreciate your help. Thanks!

Looks like is how current implementation is. https://github.com/visionmedia/mocha/pull/278 — Amitava, Aug 15 '13 at 05:34

score 18 · Answer 1 · answered Apr 23 '15 at 17:59

18

Shawn's answer works, but there is a simpler way.

If you return the Promise from your test, Mocha will handle everything for you:

it('should create new user', function() {
  return userService.create(user).then(function(model){
    expect(model.id).to.be(1); //created user ID
  });
});

No done callback needed!

answered Apr 23 '15 at 17:59

danvk

15,863
5
72
116

Promise support [was added](https://github.com/mochajs/mocha/blob/master/HISTORY.md#1180--2014-03-13) in Mocha 1.18, i.e. after this question was first asked. – danvk Apr 23 '15 at 18:04
Great! Im going to accept Shawn's answer as danvk pointed out :) – Amitava Apr 24 '15 at 07:38
Thanks. This is the best solution. – dangerginger Jun 14 '16 at 14:43

score 17 · Accepted Answer · answered May 17 '14 at 14:18

17

expect is throwing an error that is being caught by the promise. Adding a catch condition that calls done fixes this.

it('should create new user', function(done) {
    userService.create(user).then(function(model) {
        expect(model.id).to.be(1); //created user ID
        done();
    }).catch(function(e) {
        done(e);
    })
});

answered May 17 '14 at 14:18

Shawn

186
1
3

If you're using mocha 1.18 or better, danvk's answer below is better. I almost missed seeing that answer myself, so I'm commenting here for visibility. – Retsam Dec 05 '15 at 19:10

score 0 · Answer 3 · answered Aug 15 '13 at 03:20

0

Looks like done is never called. Besides then, you may also need an else to handle the failure.

answered Aug 15 '13 at 03:20

Chen

1,654
2
13
21

Mocha failed assertion causing timeout

3 Answers3

Linked