Potential Memory leak abaddressbookcopyarrayofallpeople( )

Question

This is function to reload my address book after saving changes, the line

self.addressbook=ABAddressbookCreateWithOptions()

and

self.contactAdd=ABAddressBookCopyArrayOfAllPeople(self.addressBook)

are showing as the potential memory leak points.

contactAdd is of type CFArrayRef and address book is ABAddressBookRef

  -(void)reloadAddressBook
    {
    //   if(self.addressBook)
    //       CFRelease(self.addressBook);
       self.addressBook = ABAddressBookCreateWithOptions(NULL,NULL);
        if(ABAddressBookHasUnsavedChanges(self.addressBook))
        {

            ABAddressBookSave(self.addressBook,NULL);
        }
    //    if(self.contactAdd)
    //        CFRelease(self.contactAdd);

        self.contactAdd=ABAddressBookCopyArrayOfAllPeople(self.addressBook);
    }

Use _bridge_transfer when allocating because you are assigning to CFArray which is array of core foundation with no method to release or dealloc ther array. To land it on retain, release land of Objective C use _bridge. — iEinstein, Aug 02 '13 at 06:55
@AshutoshMishra every CFRelease i gave shows a potentil memory leak.. — Raon, Aug 02 '13 at 07:01
Yeah because it is core foundation framework class so there are some leaks — iEinstein, Aug 02 '13 at 07:02
@AshutoshMishra is there any way other than changing my CFArray to NSAttay to solve this potential memory leak?? — Raon, Aug 02 '13 at 07:06
read this http://stackoverflow.com/questions/17967515/cfstringref-to-nsstring-arc-leaking-why/17967622#17967622 — iEinstein, Aug 02 '13 at 07:08
@AshutoshMishra: “it is core foundation framework class so there are some leaks” is a gross oversimplification. If you get an object from CF or something CF-based, you need to clean it up. CF does not necessarily mean leaks, and accepting leaks just because CF was involved is sloppy programming. — Peter Hosey, Aug 03 '13 at 04:59

score 2 · Answer 1 · edited Aug 29 '15 at 15:08

2

use another variable to assign like this

contactAddtemp=ABAddressBookCopyArrayOfAllPeople(self.addressBook); 
self.contactAdd=(__bridge_retained CFArrayRef) CFBridgingRelease(contactAddtemp);

It worked for me in xcode 4.2 but when I checked it doesnt work in 4.6 may be cause it uses ABAddressBookCreateWithOptions(NULL,NULL) instead of ABAddressBookCreate()

edited Aug 29 '15 at 15:08

Roozbeh Zabihollahi

7,207
45
39

answered Aug 02 '13 at 12:09

Francis F

3,157
3
41
79

Why would you call CFBridgingRelease and then immediately cast that with `__bridge_retained`? – Peter Hosey Aug 03 '13 at 04:29
It balances out, but yes there is no real sense in doing this but it seems to get the job done in xcode 4.2 – Francis F Aug 08 '13 at 05:38

score 0 · Answer 2 · answered Aug 03 '13 at 04:31

In Core Foundation, Create and Copy functions return an ownership reference.

You need to balance that out by calling CFRelease on the returned object (the Address Book, the array of people, and anything else you're getting from such functions), or by casting it with __bridge_transfer (or by calling CFBridgingRelease):

self.addressBook = CFBridgingRelease(ABAddressBookCreateWithOptions(…));

score 0 · Accepted Answer · answered Aug 05 '13 at 10:27

0

use _addressbook instead of self.addressBook.

answered Aug 05 '13 at 10:27

Francis F

3,157
3
41
79

this guy is a legend ! – Raon Aug 05 '13 at 10:28

Potential Memory leak abaddressbookcopyarrayofallpeople( )

3 Answers3

Linked