UITableView CustomCell crash on Button Click

Question

This is very common question at SO though I have google and cross check my code few times but I am not able to figure out the crash

*** -[MyCustomCell performSelector:withObject:withObject:]: message sent to deallocated instance 0x96f6980

I have a CustomCell named MyCustomCell with XIB where I have 3 buttons for Facebook,Twitter,LinkedIn. I gave them all IBAction in CustomCell class.

When I click on any of them I get this kind of crash.

I am using ARC.

In my ViewController class I have cellForRowAtIndexPath

{
        static NSString *CellIdentifier = @"MyCustomCell";
        MyCustomCell *cell = (MyCustomCell*)[myTableView dequeueReusableCellWithIdentifier:CellIdentifier];

        if (cell == nil)
        {
            NSArray *nib = [[NSBundle mainBundle] loadNibNamed:CellIdentifier owner:self options:nil];
            cell = (MyCustomCell *)[nib objectAtIndex:1];
        }
        return cell;
}


MyCustomCell.m

- (IBAction)facebookPressed:(BaseButton *)sender {

}
- (IBAction)twitterPressed:(BaseButton *)sender {

}
- (IBAction)linkedInPressed:(BaseButton *)sender {

}

Where are those button events written ? and have you actually bind all of the action to them ? — Janak Nirmal, Jul 31 '13 at 04:38
@Roshni Paste that code as well..Are you able to load the custom cells? — icodebuster, Jul 31 '13 at 04:49
Yes cells are being loaded.Its just with the click events which are getting crashed with given message — Heena, Jul 31 '13 at 04:51

score 1 · Accepted Answer · answered Jul 31 '13 at 04:37

1

I made this mistake just today! :) all you gotta do is replace the 2 lines

NSArray *nib = [[NSBundle mainBundle] loadNibNamed:@"NameOfCustomCellNibFile" owner:self options:nil];
cell = [nib objectAtIndex:1];

You have to load the loadNibNamed: with the .xib file's name. I also thought it was with the identifier, but that is regarding the name that is referenced into the cell instead of the nib for the cell.

Hope this helps!

answered Jul 31 '13 at 04:37

user2277872

2,963
1
21
22

This is not working and I have used CellIdentifier itself with the XIB name – Heena Jul 31 '13 at 04:40
then what is the MyCustomCell? – user2277872 Jul 31 '13 at 04:42
try changing the NSArray *nib = [[NSBundle mainBundle] loadNibNamed:@"NameOfCustomCellNibFile" owner:self options:nil]; to NSArray *nib = [[NSBundle mainBundle] loadNibNamed:@"MyCustomCell" owner:self options:nil]; – user2277872 Jul 31 '13 at 04:43
Yes I have tried the same code `NSArray *nib = [[NSBundle mainBundle] loadNibNamed:@"MyCustomCell" owner:self options:nil]` – Heena Jul 31 '13 at 04:48

CodenameLambda1 · Answer 2 · 2013-07-31T05:13:29.873

You've to keep the class name of cell and the XIB names same.
Keep the owner nil generally.
Also, if there is only 1 view ( i.e. 1 UITableViewCell in your case ), then this view is available at index 0 instead of index 1.
Inside the XIB file, make sure you link the button to your view itself, i.e. to IBOutlet or IBAction.
The linked buttons must be already added to your view, not floating outside in XIB. Otherwise they will instantiate and come at other indices of the loaded array. If you don't want a certain button for some time, then just keep it hidden.

So the code can be as below:

NSArray *views = [[NSBundle mainBundle] loadNibNamed:@"MyCustomCell" owner: nil options:nil];
MyCustomCell *cell = (MyCustomCell*)[views objectAtIndex:0];

Further make sure you do the following for creating XIB

Ok, then here goes the other portion simple process:

Create a MyCustomCell class derived from UITableViewCell class.
Create a separate .xib file with same name as MyCustomCell.xib.
Open .xib and delete the existing view in it. drag and drop a new
UITableViewCell from the objects of editor.
See the image to change the class name of the UITableViewCell in XIB to your class name.
Now the objectAtIndex 0 will return MyCustomCell.
Add all your buttons and other views in this UITableViewCell of your XIB.

1.Both name are same. 2.I have not yet try with owner=nil 3.On index 0 I am getting UITableviewCell and not MyCustomCell 4.I have not created IBOutlet as I only need IBAction 5.Buttons are in view itself — Heena, Jul 31 '13 at 04:57
Ok, then here goes the other portion simple process: 1. Create a MyCustomCell class derived from UITableViewCell class. 2. Create a separate .xib file with same name as MyCustomCell.xib. — CodenameLambda1, Jul 31 '13 at 05:03
I fotgot to give the Identifier name in XIB as "MyCustomCell". Your this answer remember me to cross check that also. — Heena, Jul 31 '13 at 05:19

score 1 · Answer 3 · answered Jul 31 '13 at 04:51

you can also code for Custom cell like this way. At nib of custom cell drag one UIButton and set it's tag in Xib. then use bellow Method:-

UIButton *btnMulSelected;
    - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
    {
        NSString *CellIdentifier =[NSString stringWithFormat:@"%d_%d",indexPath.section,indexPath.row];
        UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
        if (cell == nil)
        {
            [[NSBundle mainBundle]loadNibNamed:@"cell_custome_iphones" owner:self options:nil];
            cell = self.tblCell;
            self.tblCell = nil;

            btnMulSelected =(UIButton*)[cell.contentView viewWithTag:2];

            [btnMulSelected addTarget:self action:@selector(MyButtonAction:) forControlEvents:UIControlEventTouchUpInside];


        }
        return cell;
    }

Do not connect IBAction from Nib. just connect Custom-cell IBOutlate or put Unique UIButton tag from nib.

UITableView CustomCell crash on Button Click

3 Answers3