4

I have an AutoCompleteTextView that dynamically updates the list of suggestions as the user types. My problem is that as I type the list gets updated but the drop-down isn't shown! But when I delete a character (backspace) the drop-down shows up!

I even tried to explicitly call the autoText.showDropDown(); after the text change but it doesn't work.

Here is my TextChangedListener:

private TextWatcher textChecker = new TextWatcher() {
    @Override
    public void beforeTextChanged(CharSequence charSequence, int i, int i2, int i3) {

    }

    @Override
    public void onTextChanged(CharSequence charSequence, int i, int i2, int i3) {
        if(autoText.length()>9){
            new GeoTask().execute();
        }
    }

    @Override
    public void afterTextChanged(Editable editable) {
        if(autoText.length()>9){
            autoText.showDropDown();
            Log.i("UPDATE","showDropDown");
        }
    }
};

I even tried resetting the adapter above the autoText.showDropDown(); but still nothing:

autoText.setAdapter(null);
autoText.setAdapter(adapter);

Is there a way to get it to work?


EDIT: Here is the complete code of the activity. Perhaps someone can find what i am doing wrong...

public class TestDoctor extends Activity {

    TextView latText;
    TextView lngText;
    AutoCompleteTextView autoText;
    ArrayAdapter<String> adapter;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.test_doctor);

        latText = (TextView) findViewById(R.id.latTextView);
        lngText = (TextView) findViewById(R.id.longTextView);
        autoText = (AutoCompleteTextView) findViewById(R.id.autoCompleteTextView);


        Button button = (Button) findViewById(R.id.buttonDoctor);
        button.setOnClickListener(new Button.OnClickListener() {
            public void onClick(View v) {
                new GeoTask().execute();
            }
        });
        autoText.setThreshold(10);
        autoText.setHint("Οδός Αριθμός, Περιοχή");
        adapter = new ArrayAdapter<String>(this, android.R.layout.simple_dropdown_item_1line);
        autoText.setAdapter(adapter);
        adapter.setNotifyOnChange(true);
        autoText.addTextChangedListener(textChecker);
    }

    private TextWatcher textChecker = new TextWatcher() {

        @Override
        public void beforeTextChanged(CharSequence charSequence, int i, int i2, int i3){}

        @Override
        public void onTextChanged(CharSequence charSequence, int i, int i2, int i3) {
            if(autoText.length()>9){
                new GeoTask().execute();
            }
        }

        @Override
        public void afterTextChanged(Editable editable) {}
    };

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }

    private List<SimpleAddress> getAddressesFromText(String address) {
        address = address.replace(' ', '+');
        HttpHelper httpHelper = new HttpHelper();
        InputStream inputStream = httpHelper.makeHttpGetRequest("http://maps.google.com/maps/api/geocode/json?address=" + address + "&sensor=false");
        String response = httpHelper.inputStreamToString(inputStream);

        List<SimpleAddress> simpleAddresses = new ArrayList<SimpleAddress>();
        try {
            JSONObject jsonObject = new JSONObject(response);


            int size = ((JSONArray) jsonObject.get("results")).length();

            for (int i = 0; i<size; i++){
                String formatted_address = ((JSONArray) jsonObject.get("results")).getJSONObject(i)
                        .getString("formatted_address");

                Double lng = ((JSONArray) jsonObject.get("results")).getJSONObject(i)
                        .getJSONObject("geometry").getJSONObject("location")
                        .getDouble("lng");

                Double lat = ((JSONArray) jsonObject.get("results")).getJSONObject(i)
                        .getJSONObject("geometry").getJSONObject("location")
                        .getDouble("lat");
                simpleAddresses.add(i,new SimpleAddress(formatted_address,lat,lng));
            }
            return simpleAddresses;
        } catch (JSONException e) {
            return null;
        }
    }

    public class GeoTask extends AsyncTask<Void, Void, Void> {
        List<SimpleAddress> simpleAddresses = new ArrayList<SimpleAddress>();

        @Override
        protected Void doInBackground(Void... voids) {
            Log.i("UPDATE","1");
            try {
                simpleAddresses = getAddressesFromText(autoText.getText().toString());
            } catch (NullPointerException e) {
            }
            Log.i("UPDATE","2");
            return null;
        }

        @Override
        protected void onPostExecute(Void aVoid) {
            Log.i("UPDATE", "3");

            int size = simpleAddresses.size();

            if(size > 0){
                adapter.clear();
                Log.i("ADAPTER_SIZE",""+size);
                for (int i = 0; i< size; i++){
                    adapter.add(simpleAddresses.get(i).getFormatted_address());
                    Log.i("ADDED",simpleAddresses.get(i).getFormatted_address());
                }
                Log.i("UPDATE","4");
                autoText.setAdapter(null);
                autoText.setAdapter(adapter);
                autoText.showDropDown();
                Log.i("UPDATE","showDropDown");
            }
            super.onPostExecute(aVoid);
        }
    }
}

EDIT 2 i tried also this but still it doesn't work. The dropdown shows only when i press the backspace...

@Override
public void afterTextChanged(Editable editable) {
    runOnUiThread(updateAdapter);
}

...

private Runnable updateAdapter = new Runnable() {

    public void run(){
        Log.i("ADAPTER_UPDATE","start");
        adapter.notifyDataSetChanged();
        autoText.showDropDown();
        Log.i("ADAPTER_UPDATE","end");
    }
};

NOTE The problem is: I type an address. As i type nothing shows up. But i see in the logcat the the adapter is updated. But the dropdown doesn't show. Then when i delete one character the dropdown shows up??!!

Christos Baziotis
  • 5,845
  • 16
  • 59
  • 80

2 Answers2

10

Seems like you really need to implement a filter:

import java.io.InputStream;
import java.util.ArrayList;
import java.util.List;

import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;

import android.app.Activity;
import android.os.AsyncTask;
import android.os.Bundle;
import android.util.Log;
import android.view.Menu;
import android.view.View;
import android.widget.ArrayAdapter;
import android.widget.AutoCompleteTextView;
import android.widget.Button;
import android.widget.Filter;
import android.widget.TextView;

public class TestDoctor extends Activity {

  TextView latText;
  TextView lngText;
  AutoCompleteTextView autoText;
  ArrayAdapter<String> adapter;
  private Filter filter;
  private static final int ADDRESS_TRESHOLD = 10;

  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.test_doctor);

    latText = (TextView) findViewById(R.id.latTextView);
    lngText = (TextView) findViewById(R.id.longTextView);
    autoText = (AutoCompleteTextView) findViewById(R.id.autoCompleteTextView);

    Button button = (Button) findViewById(R.id.buttonDoctor);
    button.setOnClickListener(new Button.OnClickListener() {
      public void onClick(View v) {
        new AdapterUpdaterTask().execute();
      }
    });

    autoText.setThreshold(ADDRESS_TRESHOLD);
    autoText.setHint("Οδός Αριθμός, Περιοχή");

    filter = new Filter() {
      @Override
      protected void publishResults(CharSequence constraint,
          FilterResults results) {
      }

      @Override
      protected FilterResults performFiltering(CharSequence constraint) {
        Log.i("Filter",
            "Filter:" + constraint + " thread: " + Thread.currentThread());
        if (constraint != null && constraint.length() > ADDRESS_TRESHOLD) {
          Log.i("Filter", "doing a search ..");
          new AdapterUpdaterTask().execute();
        }
        return null;
      }
    };

    adapter = new ArrayAdapter<String>(this,
        android.R.layout.simple_dropdown_item_1line) {
      public android.widget.Filter getFilter() {
        return filter;
      }
    };

    autoText.setAdapter(adapter);
    adapter.setNotifyOnChange(false);
  }

  @Override
  public boolean onCreateOptionsMenu(Menu menu) {
    // Inflate the menu; this adds items to the action bar if it is present.
    getMenuInflater().inflate(R.menu.main, menu);
    return true;
  }

  private List<SimpleAddress> getAddressesFromText(String address) {
    address = address.replace(' ', '+');
    HttpHelper httpHelper = new HttpHelper();
    InputStream inputStream = httpHelper
        .makeHttpGetRequest("http://maps.google.com/maps/api/geocode/json?address="
            + address + "&sensor=false");
    String response = httpHelper.inputStreamToString(inputStream);

    List<SimpleAddress> simpleAddresses = new ArrayList<SimpleAddress>();
    try {
      JSONObject jsonObject = new JSONObject(response);

      int size = ((JSONArray) jsonObject.get("results")).length();

      for (int i = 0; i < size; i++) {
        String formatted_address = ((JSONArray) jsonObject.get("results"))
            .getJSONObject(i).getString("formatted_address");

        Double lng = ((JSONArray) jsonObject.get("results")).getJSONObject(i)
            .getJSONObject("geometry").getJSONObject("location")
            .getDouble("lng");

        Double lat = ((JSONArray) jsonObject.get("results")).getJSONObject(i)
            .getJSONObject("geometry").getJSONObject("location")
            .getDouble("lat");
        simpleAddresses.add(i, new SimpleAddress(formatted_address, lat, lng));
      }
      return simpleAddresses;
    } catch (JSONException e) {
      return null;
    }
  }

  public class AdapterUpdaterTask extends AsyncTask<Void, Void, Void> {
    List<SimpleAddress> simpleAddresses = new ArrayList<SimpleAddress>();

    @Override
    protected Void doInBackground(Void... voids) {
      Log.i("UPDATE", "1");
      try {
        simpleAddresses = getAddressesFromText(autoText.getText().toString());
      } catch (NullPointerException e) {
      }
      Log.i("UPDATE", "2");
      return null;
    }

    @Override
    protected void onPostExecute(Void aVoid) {
      Log.i("UPDATE", "3");

      int size = simpleAddresses.size();

      if (size > 0) {
        adapter.clear();
        Log.i("ADAPTER_SIZE", "" + size);
        for (int i = 0; i < size; i++) {
          adapter.add(simpleAddresses.get(i).getFormatted_address());
          Log.i("ADDED", simpleAddresses.get(i).getFormatted_address());
        }
        Log.i("UPDATE", "4");

        adapter.notifyDataSetChanged();
        autoText.showDropDown();

      }
      super.onPostExecute(aVoid);
    }
  }

}
Dan Brough
  • 2,745
  • 1
  • 24
  • 24
  • 1
    You should also make sure only one search is performed at a time and that search is only executed after a small delay in typing. – Dan Brough Jul 25 '13 at 15:35
  • Thanks!!! It worked! I had given up hope. And you are right about the delay. It will improve the performance and the user experience. Thanks again! :) – Christos Baziotis Jul 25 '13 at 16:16
  • No worries. I needed this too. – Dan Brough Jul 25 '13 at 16:19
  • Sorry, how did you set the delay before starting filtering and make sure that only one search is executed at a time? I can't figure it out... – tonix Mar 26 '14 at 22:35
  • 1
    @user3019105 use a handler: http://developer.android.com/reference/android/os/Handler.html – Dan Brough Mar 27 '14 at 11:57
  • Thanks for the response, sorry but I am a newbie in Android, is there a guide or something which shows how to use a Handler specifically with the autocompletetextview, cause I read the guide you posted in your comment but I didn't find out how to use them in this case... Thanks again! – tonix Mar 28 '14 at 19:08
  • You use a handler handle messages on a particular thread. You can remove any existing messages and then queue up a message to be sent at a later time. This can be done with the sendMessageDelayed and the removeMessages handler methods. – Dan Brough Mar 29 '14 at 14:36
  • What do { .. } in arrayAdapter initialization? ArrayAdapter is a class, not interface. What is happening there? – James121 Jun 17 '21 at 15:19
  • Answer to my previous comment is: There is an overrided anonymous class – James121 Jun 17 '21 at 17:45
3

It could have something to do with autoText.showDropDown() not being called in main thread. maybe you can try to do this instead:

autoText.getHandler().post(new Runnable() {
    @Override
    public void run() {
        autoText.showDropDown();
    }
})
Ivo
  • 18,659
  • 2
  • 23
  • 35