Firefox cuts files, whose name contains spaces, in a Struts application

Question

I am using the next class (simplified for the sake of understandability) to download images in a struts web application. It is working fine in every browser but firefox, which cuts names containing spaces. That it is to say: file with spaces.pdf gets downloaded in firefox as: file while in chrome, IE7 IE6 is downloaded as file with spaces.pdf.

public class Download extends Action {
    private static final int BUFFER_SIZE = 4096;    

    public ActionForward execute(ActionMapping mapping,
        ActionForm     form,
        HttpServletRequest request,
        HttpServletResponse response) throws Exception {
        String filename = "file with spaces.pdf";
        File file =  ... // variable containing the file;
        response.setStatus(HttpServletResponse.SC_OK);
        response.setContentType(getMimeType(request, file));
        response.setHeader("Content-Type", getMimeType(request, file));
        response.setHeader("Content-Disposition","attachment; filename="+ filename);
        InputStream is = new FileInputStream(file); 
        sendFile(is, response);
        return null;
   }  

   protected String getMimeType(HttpServletRequest request, File file) {
        ServletContext application = super.servlet.getServletContext();
        return application.getMimeType(file.getName());
   }

   protected void sendFile(InputStream is, HttpServletResponse response) throws IOException {
       BufferedInputStream in = null;
       try {
            int count;
            byte[] buffer = new byte[BUFFER_SIZE];
            in = new BufferedInputStream(is);
            ServletOutputStream out = response.getOutputStream();
            while(-1 != (count = in.read(buffer)))
                out.write(buffer, 0, count);
            out.flush();            
       } catch (IOException ioe) { 
            System.err.println("IOException in Download::sendFile"); 
            ioe.printStackTrace();
       } finally {
            if (in != null) {
                try { 
                   in.close(); 
                } catch (IOException ioe) { ioe.printStackTrace(); }
            }   
       }
    }
}

Does anyone know about what is going on here? Note i am using firefox 3.0.3 under Windows Vista.

Stephen Denne · Accepted Answer · 2013-10-21T06:06:40.010

36

The filename should be a quoted string. (According to Section 19.5.1 of RFC 2616)

response.setHeader("Content-Disposition","attachment; filename=\"" + filename + "\"");

edited Oct 21 '13 at 06:06

answered Oct 07 '08 at 10:32

Stephen Denne

36,219
10
45
60

I'm using grails and when i tried to do the same i had problems with an extra space in the end of filename, so here is my code: response.setHeader("Content-disposition", "attachment;filename=\"${meuArquivo.nome}\"") with no spaces. – leomeurer Oct 14 '13 at 17:59

JeeBee · Answer 2 · 2008-10-07T10:36:36.263

1

URLEncode the filename?

Or at least substitute %20 for the space character.

(I don't know if this will work, but give it a try)

have you tried just putting quotes around the filename as well?

edited Oct 07 '08 at 10:36

answered Oct 07 '08 at 10:26

JeeBee

17,476
5
50
60

but you might want to try using %20 instead of space first with a simple regex replace. Don't know if it will work because it's content in a HTML header but for 5 seconds work it's worth a try. – JeeBee Oct 07 '08 at 10:33

Henry B · Answer 3 · 2008-10-07T10:38:52.560

0

This is a security feature of firefox 3 I believe.

Here we go

http://support.mozilla.com/tiki-view_forum_thread.php?locale=no&forumId=1&comments_parentId=91513

It's different but it might help :)

Enjoy

edited Oct 07 '08 at 10:38

answered Oct 07 '08 at 10:25

Henry B

7,947
10
42
46

Firefox cuts files, whose name contains spaces, in a Struts application

3 Answers3