PHP MySQL Insert Code Not Working

Question

I am trying to insert some data in the database but it gives me a really confusing error

Now the error is: Parse error: syntax error, unexpected ')'

Code:

$query = mysql_query("INSERT INTO `members` VALUES (''," .$username ."," . $password . "," . $date . "," .$email . ",1'"));

You're missing a couple of concatenation operators (`.`). Also, [this](http://stackoverflow.com/questions/60174/how-to-prevent-sql-injection-in-php?rq=1). — , Jul 20 '13 at 19:03
I've removed my answer. Because there're so many errors. You should learn about basic PHP strings first. — Fallen, Jul 20 '13 at 19:13

Raz Harush · Answer 1 · 2013-07-20T19:14:32.290

0

You forgot some dots over there.

$query = mysql_query("INSERT INTO `members` VALUES (" .$username ."," . $password .  "," . $date . ","  .$email . ",1)");

edited Jul 20 '13 at 19:14

answered Jul 20 '13 at 19:04

Raz Harush

739
1
6
21

@user2489187 You also got an extra `)` after the `"`. Try this: `$query = mysql_query("INSERT INTO members VALUES (" .$username ."," . $password . "," . $date . "," .$email . ",1)");` – Raz Harush Jul 20 '13 at 19:10
Your error is the same as echo_Me's – user2489187 Jul 20 '13 at 19:15
I will work it out later. None of your answers work – user2489187 Jul 20 '13 at 19:40

echo_Me · Answer 2 · 2013-07-20T19:17:26.337

0

you have many mistakes , you forgot points . you forget ) .

you should also specify the columns names

this should work for you

$query = mysql_query("INSERT INTO `members` (firstcolumn ,username , password ,date,email , lastcolumn) VALUES ('' ,'$username','$password','$date','$email',1 )  ");
                                               ^----------^--------^-----^----^-----^^---your columns

HERE genaeral rule how to use insert :

INSERT into table (column1 , column2 , column3) VALUES (value1 , value2 , value3)

edited Jul 20 '13 at 19:17

answered Jul 20 '13 at 19:05

echo_Me

37,078
5
58
78

@user2489187 check my updated answer , you should make your columns – echo_Me Jul 20 '13 at 19:09
Now The Error is Notice: Use of undefined constant query - assumed 'query' with your code echo_Me – user2489187 Jul 20 '13 at 19:14
have you replaced your columns by what i have wrote `your columns` exactly what the values you insert – echo_Me Jul 20 '13 at 19:16
make sure you do your columns as i wrote bellow the example – echo_Me Jul 20 '13 at 19:17
yes I have replaced the columns – user2489187 Jul 20 '13 at 19:18
@echo_Me: I'm sure he has missed `$` sign before `query` at some line of his code :P – Fallen Jul 20 '13 at 19:18
i see that you insert `''` before username , so you should also use this column – echo_Me Jul 20 '13 at 19:19
I get confused with MySQL – user2489187 Jul 20 '13 at 19:21
heheeh you should convert to MYSQLI or PDO – echo_Me Jul 20 '13 at 19:22
I did miss out a $ but it still doesn't work – user2489187 Jul 20 '13 at 19:23
show your table and your code and we will see – echo_Me Jul 20 '13 at 19:23
I will work it out later. None of your answers work – user2489187 Jul 20 '13 at 19:39

score 0 · Answer 3 · answered Jul 20 '13 at 19:19

0

Try this (replace x,y,z,a,b with column name):

$query = mysql_query("INSERT INTO `members` (`x`,`y`,`z`,`a`,`b`) VALUES ('','.$username.','.$password.','.$date .','.$email.','1'"));

You haven't used ' and " in correct place.

answered Jul 20 '13 at 19:19

Mohammad Mahdi Naderi

2,975
2
14
9

I will work it out later. None of your answers work – user2489187 Jul 20 '13 at 19:40

score 0 · Answer 4 · answered Jul 20 '13 at 20:01

0

write your query and add at the end

or die(mysql_error());

what it says?

answered Jul 20 '13 at 20:01

berzins92

55
8

I did. I did if(!$query){ $query[0] = mysql_error(); return $query[0]; } – user2489187 Jul 21 '13 at 09:38

score 0 · Accepted Answer · answered Jul 23 '13 at 12:22

0

I've worked it out now. No more answers

answered Jul 23 '13 at 12:22

user2489187

1
3

PHP MySQL Insert Code Not Working

5 Answers5