How to create a model with a certain id using rspec and factory girl

Question

I use:

gem 'rails', '3.2.11'
gem 'rspec-rails', '2.13.2'
gem 'webrat', '0.7.3'
gem 'factory_girl_rails', '4.1.0'
gem 'spork', '~> 0.9.0.rc'

I want to test my HP where I always have a link to a certain user, so the pages controller for HP contains:

@user = User.find(7)

And the view HP contains:

link_to 'See user', @user

The problem is that all tests fail since test database has no user with id 7. I tried:

FactoryGirl.define do
  factory :user do
    name "Testuser"
    id "7"
  end
end

... but this doesn't work. There is always the error:

The spec is this:

describe "GET 'home'" do

    before(:each) do
      FactoryGirl.create(:user)
    end

    it "should be successful" do
      get 'home'
      response.should be_success
    end
end

Failure/Error: get 'home' ActiveRecord::RecordNotFound: Couldn't find User with id=7

The HP is working fine in reality, just the test fails. How can I assure this test is not going to fail?

Show the code of your spec if you want useful help. So far everyone is guessing. — boulder, Jul 18 '13 at 17:22

score 12 · Answer 1 · answered Jul 18 '13 at 16:04

12

Based on the Using Factories section of the documentation, I would set the id in the spec itself with something like:

@user = FactoryGirl.create(:user, :id => 7)

answered Jul 18 '13 at 16:04

James Chevalier

10,604
5
48
74

4

For those who find this question through Google. This solution works now (August 2015) – Benjamin Bouchet Aug 27 '15 at 06:11

Pierre-Louis Gottfrois · Accepted Answer · 2013-07-19T08:34:20.527

What about mocking / stubbing (much faster spec when not saving objects to database):

let(:user) { FactoryGirl.build(:user) }
let(:id) { '1' }

before do
  user.stub(:id).and_return(id) # just to illustrate, not necessary if stubbing the find class method
  User.stub(:find).and_return(user)
end

it { expect(user.id).to eq(id) } # just to illustrate
it { expect(response).to be_success }
it { expect(assigns(:user)).to eq(user) }

If you still have issue with the user being only instantiated, you can still use the above technique but replace FactoryGirl.build(:user) by FactoryGirl.create(:user)

score 3 · Answer 3 · answered Jul 18 '13 at 17:15

3

Not an answer but a suspicition... you probably shouldn't write the spec the way you are doing it.

in your spec do something like:

u=FactoryGirl.create(:user)
User.where('id=?',u.id).count.should == 1

Making your tests dependent on specific ids is a recipe for disaster.

answered Jul 18 '13 at 17:15

timpone

19,235
36
121
211

I agree with you. But the problem is that my HP has a link to this specific user. So, when I run the test the error is that the HP is not rendered since there is no user with id 7 in the test database. This is the only test I have that depends on an id, but I see no other way to avoid this. – user929062 Jul 19 '13 at 08:17

score 1 · Answer 4 · answered Jul 18 '13 at 16:02

1

You can set the ID of a user by doing something like

before
  u = FactoryGirl.create(:user)
  u.update_attribute(:id, 7)
end

However, this is a little odd. You may even run into a case where there are user's 7.

What you could do though, is use Rspec's stubs to get the proper user. For instance you could do something like

let(:user_7) { FactoryGirl.create(:user) }
before { User.stub(:find).with(7).and_return(user_7) }

answered Jul 18 '13 at 16:02

Kyle d'Oliveira

6,382
1
27
33

Thanks. The update_attribute did not change the error message... I will try to use the stubs later... – user929062 Jul 18 '13 at 16:41

score 0 · Answer 5 · answered Aug 08 '16 at 04:59

In your case I am sure you are just checking that the user id is being used instead of a specific ID.

When I write tests I just get the id returned from the database which is far more reliable and closer to what you are doing in reality.

I would write the controller spec something like this.

RSpec.describe MyController, type: :controller do
  let(:user) { FactoryGirl.create(:user) }
  before do
    # login the user here which would resolve which user id is being used
    sign_in user #assumes you are using warden test helpers
    get :home
  end

  it "allows the user to the page" do
     assert_response :ok
  end
end

This should load fine. If you wish to double check that the link is correct you should do that in a feature spec using something like capybara.

How to create a model with a certain id using rspec and factory girl

5 Answers5