MongoDB Java Driver Infinite loop while reading results

Question

I am reading MongoDB results using the following code , however the while loop runs in an infinite loop always iterating over the first element in the collection, can someone point out what I am doing wrong.

       Iterable<DBObject> list = playerData.results();
        if(list != null){
            while(list.iterator().hasNext()) {

                DBObject obj = list.iterator().next();
                DBObject id =  (DBObject) obj.get("_id");
                String player= obj.get("player").toString();
                //Populate the memcached here .
                PlayerDTO rcd = new PlayerDTO();

                if(id != null && id.get("venue" != null && id.get("score") != null) {

                    rcd.setVenue(id.get("venue").toString());
                    rcd.setScore(new Double(id.get("score").toString()).doubleValue());
                }

            }
        }

score 2 · Accepted Answer · answered Jul 12 '13 at 19:54

2

You are reassigning the original iterator to the while() loop each iteration through.

Iterator i = list.iterator();
while(i.hasNext()) {
  ....
}

answered Jul 12 '13 at 19:54

Rick Mangi

3,761
1
14
17

Or a nicer `for ( DBObject obj : list ) { do_stuff_with_obj }` – Marsellus Wallace Jul 12 '13 at 20:05
indeed. that is the cleaner way. – Rick Mangi Jul 12 '13 at 21:07
Thanks, but I am surpised to know that list.iterator() returns a new iterator everytime! – user1965449 Jul 13 '13 at 01:50
Why? I think it's pretty obvious. What if you want to iterate twice? – Rick Mangi Jul 15 '13 at 02:53

MongoDB Java Driver Infinite loop while reading results

1 Answers1