AngularJS Uncaught ReferenceError: controller is not defined from module

Question

I have the following code;

var app =
    angular.
        module("myApp",[]).
        config(function($routeProvider, $locationProvider) {
            $routeProvider.when('/someplace', {
                templateUrl: 'sometemplate.html',
                controller: SomeControl
             });
             // configure html5 to get links working on jsfiddle
             $locationProvider.html5Mode(true);
        });

app.controller('SomeControl', ...);

I get the following error

Uncaught ReferenceError: SomeControl is not defined from myApp

Is the problem just that I can not use app.controller('SomeControl', ...) syntax? when using $routeProvider? is the only working syntax:

function SomeControl(...)

duplicate of: http://stackoverflow.com/questions/11211999/using-angular-controllers-created-with-angular-module-controller — Karen Zilles, Jul 03 '13 at 17:53

score 44 · Accepted Answer · answered Jul 03 '13 at 17:56

44

Use quotes:

            controller: 'SomeControl'

answered Jul 03 '13 at 17:56

Foo L

10,977
8
40
52

2

DUH, Thanks for finding my small mistake ;) – Joshua Wooward Jul 08 '13 at 16:25

score 8 · Answer 2 · answered Jul 03 '13 at 18:13

Like Foo L said, you need to put quotes around SomeControl. If you don't use quotes, you are referring to the variable SomeControl, which is undefined because you did not use a named function to represent the controller.

When you use the alternative that you mentioned, function SomeControl(...), you define that named function. Otherwise, Angular needs to know that it needs to look up the controller in the myApp module.

Using the app.controller('SomeControl', ...) syntax is better because it does not pollute the global namespace.

score 1 · Answer 3 · answered Sep 03 '15 at 22:53

The above answers are correct however, this error can also happen :

If the name of the controller in you html or jsp etc page is not matching the actual cotnroller

<div ng-controller="yourControllerName as vm">

Also if the name of the function controller does not match the controller definition then this error can happen too.

angular.module('smart.admin.vip') .controller('yourController', yourController); function yourController($scope, gridSelections, gridCreationService, adminVipService) { var vm = this; activate();

AngularJS Uncaught ReferenceError: controller is not defined from module

3 Answers3