Android: When is it appropriate to use FragmentTransaction.remove?

Question

I thought I had understood that you're supposed to call FragmentTransaction.add() in onCreate() and FragmentTransaction.remove() in onDestroy(). My app crashes in onDestroy() with this error:

06-26 15:25:50.213: E/AndroidRuntime(579): java.lang.RuntimeException: Unable to destroy activity {com.myapp/com.myapp.MainActivity}: java.lang.IllegalStateException: Activity has been destroyed

When do I call these things if not in onCreate/onDestroy()?

You do not need to manually destroy your fragments when the activity is destroyed -- that is managed for you by the fragment framework. — CommonsWare, Jun 26 '13 at 20:32
OK. I've read that while searching online for solutions. My problem with that is that when I switch to my horizontal view, and then back to my vertical view, I now have a duplicate layout for at least one of the nested fragments. There is one layout for that fragment on top, which doesn't get updates from setText, and then another copy of that layout just below it that DOES get updates from setText. — KairisCharm, Jun 26 '13 at 20:42

score 4 · Accepted Answer · answered Jun 26 '13 at 20:46

My problem with that is that when I switch to my horizontal view, and then back to my vertical view, I now have a duplicate layout for at least one of the nested fragments.

My guess is that this is because you are always adding the fragment in onCreate(). Android automatically recreates fragments on configuration changes. Hence, onCreate() should check to see if the fragment already exists before adding it:

  @Override
  public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    if (getSupportFragmentManager().findFragmentById(android.R.id.content)==null) {
      getSupportFragmentManager().beginTransaction()
                                 .add(android.R.id.content,
                                      new RotationFragment()).commit();
    }
  }

You're probably right. But when I do if(getChildFragmentManager().findFragmentByTag("MyFrag")==null) I always get a return of true. — KairisCharm, Jun 26 '13 at 21:13

score 2 · Answer 2 · answered Jun 28 '13 at 21:11

Ok, your solution worked, except instead of using:

 if (getSupportFragmentManager().findFragmentById(android.R.id.content)==null)

I used:

 if (savedInstanceState==null)

Apparently the fragment manager is not set up by the onCreate function. But, since your answer is mostly correct, I'm marking it as an answer.

I want to thank you again. This is the second time you've been a big help to me, and I really appreciate it.

Android: When is it appropriate to use FragmentTransaction.remove?

2 Answers2