Python os.rename and os.walk together

Question

I just wrote a python script to get rid of some annoying suffixes in filenames,

here's my code:

import os

for root, dirs, files in os.walk("path"):

    for filename in files:

        if filename.endswith("[AnnoyingTag].mov"):

            os.rename(filename, filename[:-18]+'.mov')

but I got the error in the last line:

OSError: [Errno 2] No such file or directory

I am pretty sure that I have the right path because I can print out all filenames correctly.

...really have no idea why this can't work.

Thanks for your answers

Why don't you print the filename before calling rename? Try to debug. — John Zwinck, Jun 23 '13 at 05:13
I did and it prints out all the filenames correctly. I tried type(filename), and they all return strings. — Lin Ti-Wen, Jun 23 '13 at 05:16

score 13 · Answer 1 · answered Jun 23 '13 at 05:22

13

The preferred way to join paths is to use os.path.join, change this line:

os.rename(filename, filename[:-18]+'.mov')

Replace it with this:

os.rename(os.path.join(root, filename), os.path.join(root, filename[:-18]+'.mov'))

answered Jun 23 '13 at 05:22

Óscar López

232,561
37
312
386

Thanks!! It works. but may I ask further why the original code would work? – Lin Ti-Wen Jun 23 '13 at 05:40

score 8 · Accepted Answer · answered Jun 23 '13 at 05:18

8

You can replace

os.rename(filename, filename[:-18]+'.mov')

with

os.rename(root + os.sep + filename, root + os.sep + filename[:-18]+'.mov')

answered Jun 23 '13 at 05:18

su-

3,116
3
32
42

Thanks!! It works. but may I ask further why the original code would work? – Lin Ti-Wen Jun 23 '13 at 05:42
1

In os.rename function, you have to give the full path, otherwise it search the file in the directory where your script is invoked. I'm not very sure what 'why the original code would work' you meant. – su- Jun 23 '13 at 06:11
Oh I mean wouldn't. Thanks for the explanation, I learned a lot – Lin Ti-Wen Jun 23 '13 at 16:58

score 0 · Answer 3 · answered Jun 23 '13 at 05:16

Fixed:

import os

for root, dirs, files in os.walk("path"):
    for filename in files:
        if filename.endswith("[AnnoyingTag].mov"):
            os.rename(root+'\\'+filename, root+'\\'+filename[:-18]+'.mov')

I think your problem is that the files you're renaming aren't in the current working directory.

Python os.rename and os.walk together

3 Answers3

Linked

Related