Input String not in correct format (Format Exception not handled)

Question

I am trying to parse the retried value from the database into double, long, or integer, but it throws a FormatException. I need your help.

In this code, I am trying to retrieve hours from the database and sum them to calculate total hours input into the database.

String hrs;
Double resultHrs=0;

while (oleDbDataReader1.Read())
{
    hrs = oleDbDataReader1["Hours"].ToString();
    double HRS = double.Parse(oleDbDataReader1["Hours"].ToString());
    resultHrs = resultHrs + HRS;
}// end while

Jon Skeet · Answer 1 · 2013-06-18T16:53:00.357

2

Don't do the string conversion in the first place:

double hours = (double) oleDbDataReader1["Hours"];

Unless your value is actually a string in the database (in which case you should fix that) there's no reason to convert it into a string. (If it's not a type mapped to double, you should change what you cast it to, of course.)

EDIT: If it's non-numeric in the database, then you probably do need to use double.Parse - but you might want to specify the culture. For example, assuming they're all of the form "10.2" rather than "10,2" (as some cultures would use) you would want something like:

double hours = double.Parse((string) oleDbDataReader1["Hours"],
                            CultureInfo.InvariantCulture);

edited Jun 18 '13 at 16:53

answered Jun 18 '13 at 16:37

Jon Skeet

1,421,763
867
9,128
9,194

@AbeerIslam: Why is it text at all, if it's always meant to hold a number? – Jon Skeet Jun 18 '13 at 16:52
I had to cast it anyway while inputting the value into the database that was my reason for doing that however i have changed it anyway – Abeer Islam Jun 18 '13 at 17:05

Kzest · Answer 2 · 2013-06-19T03:55:20.217

1

I use:

 HRS = oledbDataReader1.GetDouble(iColumn);

where iColumn is the column index in the query

edited Jun 19 '13 at 03:55

answered Jun 18 '13 at 16:42

Kzest

526
3
4

Input String not in correct format (Format Exception not handled)

2 Answers2