C# - Where to put interface extensions?

Question

I am designing an interface in a C# project which will be extended with various extension methods. Now I thought of putting the static class containing the extension methods in the same file as the interface itself.

I am not sure though if this is against the principle of 1 thing per file. I tend to think that this is related so closely that they can go into the same file. Yet I'd still like to hear the opinion of a more experienced developer.

In terms of maintainability, code readability and good structure, what would be the way to go here? I thought of something along the lines of:

public interface IFoo
{
    int Property { get; }
    void Method();
}

public static class IFooExtensions
{
    public static void AnExtension(this IFoo foo)
    {
        // Do Something
    }

    public static void AnotherExtension(this IFoo foo)
    {
        // Do Something else
    }
}

Where all of this would go into the same file. Thanks for any advice!

Looks okay, but I would drop the `I` interface marker on the name of static class, and just make it `FooExtensions`. — p.s.w.g, Jun 11 '13 at 13:00
thanks, i get your point - the static class itself is not an interface. I will do that! :) — Dennis, Jun 11 '13 at 13:02

score 4 · Accepted Answer · edited May 23 '17 at 12:13

I find there are some practical exceptions to the "one thing per file" rule; interfaces are a common case. Perhaps you want a simple enum that's used only in the context of that interface, or you pair an interface with its implementation as mentioned by @jlew, or in your case, perhaps a couple of simple extension methods could go in the same file. But I would move them to a separate file if the implementations get to complicated.

However, remember that extension methods are made available by importing the namespace in which they are defined. So consider the typical usage of your extension method. Perhaps there is a different namespace that is associated with the specific context in which these extension methods will be used. But if these extension methods are general purpose, it would make sense to keep them in the same namespace as the interface itself, and perhaps in the same file.

Thanks for your good explanation. In my case, I would keep the extension methods in the same namespace as the interface itself, as they support using the interface itself (in general context). So I will go for the same file approach, as the interface currently is quite simple. Thanks again! — Dennis, Jun 11 '13 at 13:08

score 2 · Answer 2 · answered Jun 11 '13 at 13:00

2

I think that's fine. Files are largely irrelevant if you use the code navigation abilities of Visual Studio and tools like ReSharper. I like to put closely-related things together (like simple interfaces and their one concrete implementation).

answered Jun 11 '13 at 13:00

jlew

10,491
1
35
58

thanks for your answer, you've got a good point. I am still unsure about such basic things and I am glad for any advices like this, which will help me get along as projects get larger! – Dennis Jun 11 '13 at 13:06

score 1 · Answer 3 · answered Jun 11 '13 at 13:05

1

Go ahead with different file like interface should be in one file and the class should be in different file which will inherit the interface. If u do so u can use the interface for different classes to get the same signature. Change the class name, starting with 'I' for Interface.

answered Jun 11 '13 at 13:05

Abin

2,868
1
23
59

2

Sorry, but I think you didn't get my point. I will have implementations in different files, the class in my example is just a class for extension methods of the interface. Btw, interfaces are `implemented`, not `inherited`. – Dennis Jun 11 '13 at 13:09

C# - Where to put interface extensions?

3 Answers3