Adding control dynamically on Form is different from FlowLayoutPanel

Question

When adding usercontrol dynamically on the form i got a right ouput

using (SqlConnection myDatabaseConnection = new SqlConnection(myConnectionString.ConnectionString))
        {
            myDatabaseConnection.Open();
            using (SqlCommand SqlCommand = new SqlCommand("Select LastName from Employee", myDatabaseConnection))
            using (SqlDataAdapter da = new SqlDataAdapter(SqlCommand))
            {

                SqlDataReader DR1 = SqlCommand.ExecuteReader();
                int y = 0;
                while (DR1.Read())
                {
                    y++;
                    for (int i = 0; i < y; i++)
                    {
                        UserControl2 userconrol = new UserControl2();
                        userconrol.Location = new Point(50, 30 * i);
                        userconrol.Tag = i;
                        userconrol.LastName = (string)DR1["LastName"];
                        this.Controls.Add(userconrol);
                    }
                }
            }
        }

But when i use flowlayoutpanel to add controls dynamically this is what happened:

using (SqlConnection myDatabaseConnection = new SqlConnection(myConnectionString.ConnectionString))
        {
            myDatabaseConnection.Open();
            using (SqlCommand SqlCommand = new SqlCommand("Select LastName from Employee", myDatabaseConnection))
            using (SqlDataAdapter da = new SqlDataAdapter(SqlCommand))
            {

                SqlDataReader DR1 = SqlCommand.ExecuteReader();
                int y = 0;
                while (DR1.Read())
                {
                    y++;
                    for (int i = 0; i < y; i++)
                    {
                        UserControl2 userconrol = new UserControl2();
                        userconrol.Tag = i;
                        userconrol.LastName = (string)DR1["LastName"];
                        flowLayoutPanel1.Controls.Add(userconrol);
                    }
                }
            }
        }

What is the problem ? I use the same loop why is it when i use flowlayoutpanel to add control dynamically it doesn't show the same output?

Idle_Mind · Accepted Answer · 2013-06-04T03:49:01.520

Change the FlowDirection() of your FlowLayoutPanel to TopDown.

Edit:

Also, get rid of the for loop...what is that supposed to be doing?

Maybe something like?

    using (SqlConnection myDatabaseConnection = new SqlConnection(myConnectionString.ConnectionString))
    {
        myDatabaseConnection.Open();
        using (SqlCommand SqlCommand = new SqlCommand("Select LastName from Student", myDatabaseConnection))
        using (SqlDataAdapter da = new SqlDataAdapter(SqlCommand))
        {
            int i = 0;
            SqlDataReader DR1 = SqlCommand.ExecuteReader();
            while (DR1.Read())
            {
                i++;
                UserControl2 userconrol = new UserControl2();
                userconrol.Tag = i;
                userconrol.LastName = (string)DR1["LastName"];
                flowLayoutPanel1.Controls.Add(userconrol);
            }
        }
    }

Thank you. I just made everything complicated where it is simple as that. :) — Karlx Swanovski, Jun 04 '13 at 04:15

score 0 · Answer 2 · answered Jun 04 '13 at 04:02

using (SqlConnection myDatabaseConnection = new SqlConnection(myConnectionString.ConnectionString))
        {
            myDatabaseConnection.Open();
            using (SqlCommand SqlCommand = new SqlCommand("Select LastName from Employee", myDatabaseConnection))
            using (SqlDataAdapter da = new SqlDataAdapter(SqlCommand))
            {
                List<string> list1 = new List<string>();
                SqlDataReader DR1 = SqlCommand.ExecuteReader();
                while (DR1.Read())
                {
                    list1.Add((string)DR1["LastName"]);
                }

                int i = 0;
                foreach (string LastName in list1)
                {
                    i++;
                    UserControl2 userconrol = new UserControl2();
                    userconrol.Tag = i;
                    userconrol.LastName = LastName;
                    flowLayoutPanel1.Controls.Add(userconrol);
                }
            }
        }

Adding control dynamically on Form is different from FlowLayoutPanel

2 Answers2