5

I ran into this scenario.

class MyForm extends IdSelectionForm {
  private Boolean approveIt = true;
  .....
}

my JSTL form consists of

<html:checkbox property="approveIt" styleId="style1" value="true"/>

When I select checkbox and submit. In struts action I get true value set for this field. And again when I uncheck it and submit. Then also I get true value. I am wondering if it is something with default value. Should it be overridden by false when I uncheck.

Aleksandr M
  • 24,264
  • 12
  • 69
  • 143
prakashpoudel
  • 565
  • 2
  • 9
  • 25

3 Answers3

8

First of all, <html:checkbox> is a Struts tag not a JSTL tag. This tag simply generates a standard HTML input of type checkbox. And HTML checkboxes send their value as parameter value when they're checked, and don't send any parameter when they're unchecked.

So, since the default value of your form field is true:

  • if the checkbox is checked, it will be set to true by Struts
  • if the checkbox is unchecked, it won't be set to anything by Struts, and will thus keep its default value: true

The default value of the approveIt property should be false. That way, if the checkbox is unchecked, it will keep its default value (false), which is correct. And if the checkbox is checked, it will be set to true, which is also correct.

Roman C
  • 49,761
  • 33
  • 66
  • 176
JB Nizet
  • 678,734
  • 91
  • 1,224
  • 1,255
2

The value attribute contains the value used by the tag and has nothing with checkbox state, if it's checked or unchecked.

On submit, only checked checkboxes are passed. Then Struts catches them and set corresponding by name bean properties.

If you per-initialize the value inline or in constructor then only checked checkboxes will be updated by setting a bean property value. You cannot update the unchecked state.

Therefore don't set any value before the form is populated. If the value is not set then Struts treats that value as false and removes checked from the tag. This is equivalent by setting the value to false explicitly.

The opposite behavior with the value true but checkbox has not a state for the other values like null rather than true or false that corresponds to the state of checkbox checked or unchecked (without checked attribute).

Roman C
  • 49,761
  • 33
  • 66
  • 176
2

I was having the same problem. The problem persisted even after the boolean variable was initialized to false.

The problem was my scope was session.

Upon changing the scope to request everything works as expected.

Madness
  • 2,730
  • 3
  • 20
  • 29
user2091897
  • 63
  • 9