Check my code, I‘m using ThreadLocal to manage HttpSession

Question

I'm use ThreadLocal to manage HttpSession. code as below:

public class HttpSessionLocal {

    private static ThreadLocal<HttpSession> threadLocal = new ThreadLocal<HttpSession>();

    public static HttpSession getSession(HttpServletRequest request) {
        HttpSession session = threadLocal.get();
        if (session == null) {
            threadLocal.set(request.getSession());
        }
        return threadLocal.get();
    }

    public static void setSession(HttpSession session) {
        threadLocal.set(session);
    }

}


public class SessionListener implements HttpSessionListener {

    public void sessionCreated(HttpSessionEvent httpSessionEvent) {
    }

    public void sessionDestroyed(HttpSessionEvent httpSessionEvent) {
        HttpSessionLocal.setSession(null);
    }
}

Can we do this? If not, how can we improve it? Thanks!

score 0 · Accepted Answer · edited Nov 27 '19 at 05:31

0

It makes no sense. HttpServletRequest.getSession() returns the same HttpSession object for all requests within the same session. You don't need to cache it. Besides, HttpSession is not thread bound, requests within the same session may come in different threads.

edited Nov 27 '19 at 05:31

Shafin Mahmud

3,831
1
23
35

answered May 25 '13 at 08:49

Evgeniy Dorofeev

133,369
30
199
275

actually I have got a problem， that one user found his username is another people when he was login in website. But I have save the user information in httpsession. I think the session is mixed up, but the frequency is very low. So I decided to use Threadlocal to management httpsession. – albert May 26 '13 at 10:24

score 0 · Answer 2 · answered May 25 '13 at 08:52

0

You're code will not work as intended as the http request thread is different than the thread spawn by the container to deal with the sessionDestroyed event.

I can't imagine why you keep the http session in a thread local and require the HttpServletRequest as argument to the HttpSessionLocal.getSession. If you have a reference to the request you can get the http session with: request.getSession().

answered May 25 '13 at 08:52

dcernahoschi

14,968
5
37
59

actually I have got a problem， that one user found his username is another people when he was login in website. But I have save the user information in httpsession. I think the session is mixed up. So I decided to use Threadlocal to management httpsession. – albert May 26 '13 at 10:19

Check my code, I‘m using ThreadLocal to manage HttpSession

2 Answers2