T in class? AddRange ICollection?

Question

I try to do static class, add to icollection but i got some issues i cant seem to overcome. that is how i get so i can pass a ICollection in the method? cause T is that say it can not be resolved.

and then i wonder is there a way to do AddRange on icollection?

i was thinking of something like this but maby i am way out of my mind with it?

public static ICollection<T> add(this IEnumerable<T> list)
    {
        ICollection<T> collection = null;

        return collection.AddRange(list);            
    }

score 17 · Accepted Answer · answered Nov 03 '09 at 14:24

17

No, ICollection<T> doesn't have an AddRange method - and even if it did, you'd be trying to dereference null which will throw a NullReferenceException. You haven't specified a collection to add the list to... what exactly are you trying to do?

You could create (say) a new List<T> - and that has the benefit of already having a constructor which can take an IEnumerable<T>:

public static ICollection<T> Add<T>(this IEnumerable<T> list)
{
    return new List<T>(list);            
}

However, at that point you've really just reimplemented Enumerable.ToList() and given it a different return type...

If you want to add everything to an existing collection, you might want something like this:

public static ICollection<T> AddTo<T>(this IEnumerable<T> list,
                                      ICollection<T> collection)
{
    foreach (T item in list)
    {
        collection.Add(item);
    }
    return collection;
}

answered Nov 03 '09 at 14:24

Jon Skeet

1,421,763
867
9,128
9,194

Love the new name...had no idea who it was either. :-P – Justin Niessner Nov 03 '09 at 14:26
You are missing a generic method argument :) – leppie Nov 03 '09 at 14:27
@Joel: Hence "at that point you've really just reimplemented Enumerable.ToList() and given it a different return type..." :) – Jon Skeet Nov 03 '09 at 14:30
In .Net 4.0 `List` has an `AddRange` method - also `InsertRange`, `RemoveRange` ...actually, MSDN shows it available in 3.5 – IAbstract Jan 05 '12 at 00:29
@IAbstract: Sure, but this is for `ICollection`, not `List` – Jon Skeet Jan 05 '12 at 06:19
duly noted :) ...since `List` implements `ICollection` I thought it relevant. – IAbstract Jan 05 '12 at 15:35
Would it not be better to have the sig ``public static Q AddTo(this IEnumerable list, Q collection) where Q : ICollection``? This would help chaining if you wanted to keep the input and output type the same? – bradgonesurfing Feb 12 '14 at 07:42

score 4 · Answer 2 · answered Nov 03 '09 at 14:27

4

If I understand correctly you want to add a IEnumerable<T> to an empty collection.

Wouldn't it be easier to just do:

ICollection<MyObject> collection = new List<MyObject>(GetIEnumerableOfMyObject());

Or even:

ICollection<MyObject> collection = GetIEnumerableOfMyObject().ToList();

answered Nov 03 '09 at 14:27

Yannick Motton

34,761
4
39
55

i did not know i could do a ICollection then do the list like that. – Dejan.S Nov 03 '09 at 14:37
`List` implements `ICollection` so yup. – Yannick Motton Nov 03 '09 at 14:42

score 1 · Answer 3 · answered Jan 08 '13 at 21:42

The other ways seem to assume that your ICollection is empty and/or your ICollection is a type of List. However, if you want AddRange, then you can Extend the ICollection class as follows:

public static void AddRange<T>(this ICollection<T> ic, IEnumerable<T> ie)
{
    foreach (T obj in ie)
    {
        ic.Add(obj);
    }
}

Note, however, that since List impliments ICollection, this may cause ambiguity when dealing directly with List objects (though I haven't tested yet if the compiler will be able to resolve it--my gut reaction is that it should, though, since AddRange is a member of List and the compiler will go through member functions first before looking at extensions, but if I'm wrong I'm sure someone will correct me).

score 0 · Answer 4 · answered Jul 27 '12 at 10:33

0

Depending on the collection type of your source list an alternative approach is to use List(T).ForEach, as in:

List<string> source = ...
ICollection<string> dest = ...

source.Foreach(dest.Add);

However, the readability of this is easy to dispute.

answered Jul 27 '12 at 10:33

Richard Ev

52,939
59
191
278

T in class? AddRange ICollection?

4 Answers4

Linked