is there something like dbgeometry makevalid in .net 4.5

Question

I'm trying to calculate area of polyline like that

    string poly = "POLYGON ((637604.918432772 2230520.64934531,
637622.257266129 2230419.44632915, 637279.107128549 2230192.04910755, 636765.470527745 2230179.6468564, 636778.005055813 2229861.77192838, 636529.81646905 2229464.29327025, 635813.486592791 2229523.30345774, 636017.385069448 2229974.32341381, 636267.323659164 2230070.32127916, 637035.026966561 2230404.70764784, 637275.265066307 2230401.13408429, 637604.918432772 2230520.64934531, 637604.918432772 2230520.64934531))";
     DbGeometry gm = DbGeometry.FromText(poly, 32637);
double area= gm.Area.Value; // here I got the error Exception has been thrown by the target of an invocation.

I noticed later that the reson of error that the dbgeometry is invalid I try the code in ms sql 2012 also give me the error but when I tried like that

SELECT @gm.MakeValid().STArea()

thats worked in sql my question is there is away to make the geometry valid in .net thank you

score 9 · Answer 1 · answered Oct 06 '13 at 21:34

You definitely should not go to the DB to get what you want. A simple and fast method is to extend DbGeography by adding the following code to your project:

using System.Data.SqlTypes;
using Microsoft.SqlServer.Types;

namespace System.Data.Spatial
{
    public static class DbGeometryExtension
    {
        public static DbGeometry MakeValid(this DbGeometry geom)
        {
            if (geom.IsValid)
                return geom;

            return DbGeometry.FromText(SqlGeometry.STGeomFromText(new SqlChars(geom.AsText()), 4326).MakeValid().STAsText().ToSqlString().ToString(), 4326);

        }
    }
}

There are a few assumptions made when creating this code so don't use it "as is".

Note that the projection above is `32637` and not `4326` – jocull Jul 31 '14 at 16:57 — jocull, Jul 31 '14 at 16:57

score 6 · Accepted Answer · answered May 29 '13 at 10:53

6

I'd agree with Bojan, unless you are using the Entity Framework?

The SqlGeometry object has a MakeValid() function, so using your example, allowing for a convert between DbGeography and SqlGeography:

DbGeography geog;
SqlGeometry geom = SqlGeometry.STGeomFromWKB(new SqlBytes(geog.AsBinary()), 32637);

However, unless you are using EF, I'd recommend simply using SqlGeometry as

There is no cast / conversion
SqlGeometry has far more functions available than DbGeometry.

Hope that helps.

answered May 29 '13 at 10:53

Jon Bellamy

3,333
20
23

I'm using entity framework 5 can i use sqlgeometry then assign it to dbgeometry – Khalid Omar May 30 '13 at 00:50
1

@Khalid, ultimately, yes, you're restricted to DBGeometry within EF5 but you can read it from the DB, convert it to SQLGeometry, perform whatever you need to, convert it back to DBGeometry and update the DB (if needed). However, whilst a single conversion is a negligible overhead, this can quickly become significant when doing with large quantities of objects. My question to you is therefore, why exactly do you HAVE to convert it, there are valid reasons, but I'm trying to make sure I best advise. – Jon Bellamy May 30 '13 at 11:36

Bojan Resnik · Answer 3 · 2013-05-20T00:55:22.717

4

~~SqlSpatialFunctions.MakeValid is a SQL Server-specific method to do that.~~

If you are interested why your geometry is invalid, you can ask SQL Server:

SELECT @gm.IsValidDetailed()

Also, you might want to consider using SQL Server geometry type directly: SqlGeometry.MakeValid.

edited May 20 '13 at 00:55

answered May 20 '13 at 00:24

Bojan Resnik

7,320
28
29

how can I use SqlSpatialFunctions with in c# to dbgeometry valid – Khalid Omar May 20 '13 at 00:46
gm = SqlSpatialFunctions.MakeValid(gm); give me This function can only be invoked from LINQ to Entities. – Khalid Omar May 20 '13 at 00:49
1

Ah, sorry, my bad - that seems to be just a way to get LINQ to invoke SQL's MakeValid on database objects. I've updated my answer. – Bojan Resnik May 20 '13 at 00:55

score 0 · Answer 4 · answered May 26 '13 at 09:25

here a medium solve to that problem that i make scallar function like that

CREATE FUNCTION [dbo].[GeomMakeValid](@geom as geometry)
RETURNS geometry
AS
BEGIN

DECLARE @gm as geometry;
set @gm = @geom.MakeValid();

return (@gm);
END

GO

then i call it from model like that

public static DbGeometry geoMakeValid(DbGeometry geom)
      {

          EntityConnection Connec = getConnection();

          DbCommand com = Connec.StoreConnection.CreateCommand();
          com.CommandText = "select dbo.GeomMakeValid(@geom)";
          com.CommandType = System.Data.CommandType.Text;
          com.Parameters.Add(new SqlParameter("@geom", geom.AsText()));
          if (com.Connection.State == ConnectionState.Closed) com.Connection.Open();
          try
          {
              var result = com.ExecuteScalar(); // should properly get your value
              Connec.Close();
              return DbGeometry.FromText( result.ToString(),geom.CoordinateSystemId);

          }
          catch (System.Exception e)
          {

          }
          Connec.Close();
          return geom;
      }

any any part of code i can call this function to make geometry valid

Since your code is already SQL Server specific, then it would be much cleaner and faster to use `SqlGeometry` objects in your code instead of `DbGeometry`, rather than doing the entire roundtrip to the database. — Bojan Resnik, May 29 '13 at 00:18

is there something like dbgeometry makevalid in .net 4.5

4 Answers4

Linked