App crash while updating database

Question

I'm currently developing an android app with eclipse. I got a problem while updating the database. The problem is the app crash while the updateFlag method is called. The updateFlag method only update one specific column only based on the rowId.

This is my database structure in SQLiteAdapter class:

public long insert(String answer, String question, String hint, String flag, String level){

  ContentValues contentValues = new ContentValues();
  contentValues.put(KEY_ANSWER, answer);
  contentValues.put(KEY_QUESTION, question);
  contentValues.put(KEY_HINT, hint);
  contentValues.put(KEY_FLAG, flag);
  contentValues.put(KEY_LEVEL, level);
  return sqLiteDatabase.insert(MYDATABASE_TABLE, null, contentValues);
 }

This is the update method in SQLiteAdapter class:

public void updateFlag(long rowId)
    {
        ContentValues args = new ContentValues();
        args.put(KEY_FLAG, "1");
        sqLiteDatabase.update(MYDATABASE_TABLE, args, KEY_ROWID + "=" + rowId, null);
    }

And this is how I call the updateFlag method in another class:

        mySQLiteAdapterListener2 = new SQLiteAdapter(this);
        mySQLiteAdapterListener2.openToWrite();
        long idListener = Long.parseLong(getId);
        mySQLiteAdapterListener2.updateFlag(idListener);
        mySQLiteAdapterListener2.close();

What's wrong with my code? Anyone know how to update one specific column based on rowId in the right way?

I initialize it in the onClickListener. So when user press the button it will update the database — Bobby Chandra, May 15 '13 at 16:20
can you show the code of *onClickListener*? and your logcat, even if you believe there isn't any relevant on it... — DigCamara, May 15 '13 at 16:23
It fixed. Nothing wrong with the with the code. The real problem is on showing the updated data. But, I want to say thank you for trying to help me to solve this problem. I'm sorry for bothering you with this question — Bobby Chandra, May 15 '13 at 18:22

Chintan Soni · Answer 1 · 2013-05-16T04:03:09.717

2

SQLiteDatabase update method takes four arguments:

database.update(String table_name, ContentValues values, String selection, String[] selectionArgs);

So, your query should be like in your below updateFlag method. Replace your updateFlag method with this one and try this.

public void updateFlag(long rowId)
    {
        ContentValues args = new ContentValues();
        args.put(KEY_FLAG, "1");
        sqLiteDatabase.update(MYDATABASE_TABLE, args, KEY_ROWID + "=?", new String[]{rowId+""});
    }

edited May 16 '13 at 04:03

answered May 15 '13 at 16:19

Chintan Soni

24,761
25
106
174

The documentation actually states that you can give null as the two last arguments.http://developer.android.com/reference/android/database/sqlite/SQLiteDatabase.html#update(java.lang.String, android.content.ContentValues, java.lang.String, java.lang.String[])) – DigCamara May 15 '13 at 17:48
@DigCamara Yes ofcourse. In that case all the rows will be affected. Check the documentation once again. In the present scenario, if you pass `NULL`, `NULL` in the last two arguments, then all the rows will be updated to the value "1" in the column "KEY_FLAG". – Chintan Soni May 16 '13 at 04:02

score 1 · Answer 2 · answered May 15 '13 at 16:08

Try this:

sqLiteDatabase.update(MYDATABASE_TABLE, args, KEY_ROWID + "=?", new String[] {rowId});

The last parameters if for passing the values that will replace the '?'.

This assumes you have a problem with your update. You need to post a stacktrace so we can see where the app is crashing.

App crash while updating database

2 Answers2