What's wrong with this piece of code? I don't know how to solve this issue

Question

Trying to create an element with some custom properties

function x(){
    var f=document.createElement("div");
    this.name="monkey";
    return f;
}
x.prototype.myFunction=function(){
    alert(arguments[0]+this.name);
};
var c=new x();
c.myFunction("hello");

The browser says that c.myFunction is not a function

Don't return anything. You are using it as a constructor, so it will automatically instantiate it as a new object. — Jeff Shaver, May 08 '13 at 11:39

score 5 · Accepted Answer · answered May 08 '13 at 11:38

5

You are returning an HTML element in your function, so c will have a reference to the element and not your object.

Remove return f; and you'll get your expected output of an alert box containing 'hellomonkey'

answered May 08 '13 at 11:38

Matt Cain

5,638
3
36
45

But then I get the error that there is no `appendChild()` method when I call `x.appendChild(document.createTextNode("I am a monkey"))`; – Romantic Electron May 08 '13 at 11:49
so define `this.that = $(this);`, then use `x.that.appendChild();` – Bill May 08 '13 at 11:50
3

@Billy Mathews, introducing jquery into this question is not useful. – Xotic750 May 08 '13 at 12:16
@Xotic750 You're right, for some reason I thought `.appendChild` was a jQuery method. So change to `this.that = this;` – Bill May 08 '13 at 12:33

score 0 · Answer 2 · answered May 08 '13 at 11:39

0

Is this ok for you?

function x(){
  var f=document.createElement("div");
  this.name="monkey";

  this.myFunction=function(){
    alert(arguments[0]+this.name);
  };

  this.returnDiv = function() {
    return f;
  }

  return this;
}
var c=new x();
c.myFunction("hello");

answered May 08 '13 at 11:39

Filipe Melo

558
5
10

I want to inherit that property but I want to make an Element – Romantic Electron May 08 '13 at 11:41

What's wrong with this piece of code? I don't know how to solve this issue

2 Answers2