ArrayList returning wrong value

Question

This is related to Array of objects in a class. I originally added it on to that question but because that question was answered I wasn't getting responses.

So I have 2 classes. One containing a list of the other class. And I am adding data into the class that I have pulled out of the database. However when I go to pull the data back out of the List, values are all the same. They are the values of the last element in the list.

I have tried creating the object anew in each loop but it still seems to be causing a problem. I don't see what I am doing wrong here.

public class xmldata {
    String Barcode;
    String First;
    String Last;
    String Phone;
    String Email;

    String md5sum;

    String zipfile;

    List<PictureData> pics = new ArrayList<PictureData>();

...

public class PictureData {

    static String filename;
    static String directory;

...

xmldata data = new xmldata();

ResultSet pictures=db.query("select * from pictures where barcode=?",barcode);



while (pictures.next()) {
    PictureData pictemp= new PictureData();
    pictemp.setdirectory(pictures.getString("path"));
    pictemp.setfilename(pictures.getString("filename"));
    data.pics.add(pictemp);     
}

...

for (int j=0; j<data.pics.size();++j) {

    String path;
    PictureData pictemp2= new PictureData();

    pictemp2=(PictureData) data.pics.get(j);
    path=pictemp2.getdirectory()+pictemp2.getfilename();

    System.out.println(path);

    zip.addfile(path);

}

Have you breaked after your while to see the content in data.pics ? — Alexandre Lavoie, Apr 28 '13 at 02:44
It doesn't actually tell me what's in there. It just lists pics>elementData>[0]PictureData(id=43) and pics>elementData>[1]PictureData(id=45) — Codeguy007, Apr 28 '13 at 02:50
@JermaineXu: check the previous post he has mentioned. Its there. — Lokesh, Apr 28 '13 at 02:52
You can remove this line : = new PictureData(); since you only need to create a new at the insert. — Alexandre Lavoie, Apr 28 '13 at 02:57
Thanks Alexandre, The secondary pictemp was just added as an attempt to solve the problem. — Codeguy007, Apr 28 '13 at 02:59

score 5 · Accepted Answer · answered Apr 28 '13 at 02:50

5

Problem is here:

public class PictureData {

    static String filename;
    static String directory;

}

Why have you made filename and directory static? it can contain only one value. Make them non static and it will work.

answered Apr 28 '13 at 02:50

Lokesh

7,810
6
48
78

So eventhough, I had multiple instances of the class, it could only hold one value because it was static and thus the same against all instances? – Codeguy007 Apr 28 '13 at 02:56
1

@Codeguy007: Yup , static is at class level not instance level. – Lokesh Apr 28 '13 at 02:57
I have the same problem and I also havent declared them static. not sure why – Srujan Barai Oct 30 '15 at 06:02

ArrayList returning wrong value

1 Answers1