How do I not allow negative numbers?

Question

 public boolean add(int v) 
    {
        if (count < list.length)      //  if there is still an available slot in the array 
           {
           if (v >= minValue || v <= maxValue) // if the value is within range
                {
                list[count] = v;    // add the value to the next available slot
                count++;          // increment the counter
                return true;       // all okay ; Value added
                }
           else 
                {
                System.out.println("Error: The value is out of range. Value not added");
                return false;
                }
           }
        else 
           {
           System.out.println("Error: The list is full. Value not added.");
           return false;
           }
    }

4

what is the question ? – Frederik.L Apr 25 '13 at 19:55

bfitzpatrick · Answer 1 · 2013-04-25T20:04:40.180

2

Assuming minValue is greater than zero, you should change the || to an && to check both ends of the range at the same time.

if (v >= minValue && v <= maxValue)

If minValue is not necessarily greater than zero

if (v >= minValue && v <= maxValue && v >= 0)

edited Apr 25 '13 at 20:04

answered Apr 25 '13 at 19:56

bfitzpatrick

1,513
11
13

1

Shouldn't it be `&&` in-place of `||` to have the values in min max range? – Smit Apr 25 '13 at 19:58
You're right, Smit. That error was copied from the question though. – Brian Apr 25 '13 at 20:01

score 1 · Accepted Answer · answered Apr 25 '13 at 19:59

1

It should be considering minValue and maxValue are positive

if (v >= minValue && v <= maxValue)

if minValue is negative then you can add one more check

if(v >= 0)

answered Apr 25 '13 at 19:59

Smit

4,685
1
24
28

How do I not allow negative numbers?

2 Answers2