Declaring a variable and its type in a conditional statement

Question

I'm trying to do this in Java:

if(this.ssl == true) {
    HttpsURLConnection connection = (HttpsURLConnection) new URL(address).openConnection();
}
else {
    HttpURLConnection connection = (HttpURLConnection) new URL(address).openConnection();
}
connection.setDoOutput(true);
connection.setRequestMethod("POST");

But the last two lines are throwing an error saying that the variable can't be found. Is this not possible in Java? I know about declaring a variable in this situation with the same type (declaring it outside the conditional and initializing it inside the conditional) but in this case the type is not the same based on the condition.

For reference, here is my class so far:

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.io.UnsupportedEncodingException;
import java.net.HttpURLConnection;
import java.net.URL;
import java.net.URLEncoder;
import javax.net.ssl.HttpsURLConnection;

public class Post {

    private String data;
    private boolean ssl;

    public Post(boolean ssl) {
        this.ssl = ssl;
    }

    public String sendRequest(String address) throws IOException {

        //Only send the request if there is data to be sent!
        if (!data.isEmpty()) {
            if (this.ssl == true) {
                HttpsURLConnection connection = (HttpsURLConnection) new URL(address).openConnection();
            } else {
                HttpURLConnection connection = (HttpURLConnection) new URL(address).openConnection();
            }
            connection.setDoOutput(true);
            connection.setRequestMethod("POST");
            OutputStreamWriter writer = new OutputStreamWriter(connection.getOutputStream());
            writer.write(data);
            BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
            StringBuilder response = new StringBuilder();
            reader.close();
            writer.close();
            return response.toString();
        } else {
            return null;
        }
    }

    public void setData(String[] keys, String[] values) throws UnsupportedEncodingException {
        //Take in the values and put them in the right format for a post request
        for (int i = 0; i < values.length; i++) {
            this.data += URLEncoder.encode(keys[i], "UTF-8") + "=" + URLEncoder.encode(values[i], "UTF-8");
            if (i + 1 < values.length) {
                this.data += "&";
            }
        }
    }
}

ddavison · Answer 1 · 2013-04-24T18:28:44.633

This is a scope issue.

Change it to

public String sendRequest(String address) throws IOException {
   HttpURLConnection connection = null;
   //Only send the request if there is data to be sent!
   if (!data.isEmpty()) {
       if (this.ssl) {
         connection = (HttpsURLConnection) new URL(address).openConnection();
       } else {
         connection = (HttpURLConnection) new URL(address).openConnection();
       }
   }
   connection.setDoOutput(true);
   connection.setRequestMethod("POST");
   ...

You were attempting to access connection when it was being defined within an if statement. Ergo, nothing else had access to this variable.

Thank you! I had no idea the type could be casted. – Aaron Apr 24 '13 at 18:34 — Aaron, Apr 24 '13 at 18:34

score 2 · Accepted Answer · edited May 23 '17 at 10:25

2

See this. In java, how to create HttpsURLConnection or HttpURLConnection based on the url?

Basically since HttpsURLConnection extends HttpUrlConnection you don't need to declare in the if statement.

edited May 23 '17 at 10:25

Community

1
1

answered Apr 24 '13 at 18:23

Jias

164
12

Wow, I didn't even check that. I had no idea I could just cast it. Thanks, what a dumb question... – Aaron Apr 24 '13 at 18:31

score 0 · Answer 3 · answered Apr 24 '13 at 18:23

Your connection variables are declared within very short blocks and they are out of scope by the time you attempt to call methods on them.

Declare one connection variable before the block, and set it in each case, so that the variable is still in scope by that time you call methods on it.

HttpURLConnection connection;
if(this.ssl == true) {
    connection = (HttpsURLConnection) new URL(address).openConnection();
}
else {
    connection = (HttpURLConnection) new URL(address).openConnection();
}
connection.setDoOutput(true);
connection.setRequestMethod("POST");

Declaring a variable and its type in a conditional statement

3 Answers3