0

I am trying to fix a real crappy ASP.net 4.0 program handed to me. The people who wrote it did not use the normal asp.net standards. I myself am fairly new to ASP.net and try to learn more about it any chance I can get. In any event it is an ASP.Net 4.0 webforms app with C# code behind.

I am dealing with a page where it has a call to a code behind method in the markup itself. We can call this method get detailById. This method makes a call to a web service which queries the database with this id and returns a dataset to the code behind. Once all this data is received, it is written to the screen in a table. That is it for this method. At the bottom of this page exists various buttons that do different functions. Lets take one button called Hello, for example. All this button has to do is access one of the fields(ex: Username) that were gotten in the detailById method. How do I do make this variable value available to all code behind methods? I considered the following thoughts:

  1. Requery database like detailById did to get this field, but this seems awfully inefficient.

  2. Created a class level variable for the page and set the value of it to the Username variable in the detailById method. This did't work. When I clicked on the "Hello" button, the Username was missing. I know for a fact it was acquired in the detialById method.

  3. Then I thought that postback might be responsible for the value disappearing, so I stored the Username value in a ViewState variable while in the detailById method. When I tried to access this variable it too was null. I have no idea why.

  4. Finally, I put this value in Session while in the detailById method. This worked and the value was able to be referenced in my various code behind methods. This feels like a wrong way to do this. Am I right?

What is the good/correct way to do this?

I hope I made my question clear. Thanks.

user1911835
  • 55
  • 5

2 Answers2

0

I suggest to put it in ViewState (#3). But you have to make sure that you have EnableViewState=True and ViewStateMode=Enabled on the @Page markup (actually these are the defaults). I prefer to use a property to wrap the store/retrieve work by a property like:

private string UserName
{
    get
    {
        return ViewState["__userId"] as string;
    }

    set
    {
        ViewState["__userId"] = value;
    }
}

And more importantly, you will have to call that getDetailById method from Page_Load. Because, embedded code on aspx page gets called at rendering stage, before which ViewState is already saved (check here). If it is impossible to move that code into Page_Load, Session (#4) is left to do the work.

Community
  • 1
  • 1
mshsayem
  • 17,557
  • 11
  • 61
  • 69
  • Your comments were very helpful and exactly on the mark. I did not know this info before you mentioned it. I used session to store it in the version I was fixing. Recently I rewrote it and was able to use Viewstate properly once I moved the code to the Page_load event. Thanks! – user1911835 Jul 17 '13 at 04:30
0

session is a good solution. you can use sessionState mode="SQLServer" for better session performance and security. ref: http://support.microsoft.com/kb/317604

YaakovHatam
  • 2,314
  • 2
  • 22
  • 40