0

I'm trying to wirte a bash script that will dynamically construct the command I need to execute. (merging lcov files)

So far I'm able to construct the command line, here is the result:

#!/bin/bash
LCOV_INPUT_FILES=""
while read FILENAME; do
    LCOV_INPUT_FILES="$LCOV_INPUT_FILES -a \"$FILENAME\""
done < <( find ../reports/coverage -name lcov.info )

echo lcov "${LCOV_INPUT_FILES}" -o ../reports/coverage.lcov
lcov "${LCOV_INPUT_FILES}" -o ../reports/coverage.lcov

If I run the line the echo outputs in my shell it works, but I cannot run this command from my script, and I lack of bash greatness to debug it.

Here is the kind of output I get from the echo:

lcov  -a "../reports/coverage/Chrome 26.0 (Linux)/lcov.info" -a "../reports/coverage/Firefox 20.0 (Linux)/lcov.info" -a "../reports/coverage/PhantomJS 1.8 (Linux)/lcov.info" -o ../reports/coverage.lcov

Do you know what could be wrong here?

Regards,

Xavier

xavier.seignard
  • 11,254
  • 13
  • 51
  • 75

1 Answers1

3

If you use double quotes "${LCOV_INPUT_FILES}", bash treats the whole string as one word. Without double quotest, bash would split the variable's value on whitespace.

For the way you constructed the string the only option is to use eval:

eval lcov "$LCOV_INPUT_FILES" -o ...

There are other options, too. You can use an array to store the parameters

LCOV_INPUT_FILES+=(-a "$FILENAME")

and then just expand the array in double quotes:

lcov "${LCOV_INPUT_FILES[@]}" -o ...
choroba
  • 231,213
  • 25
  • 204
  • 289
  • 1
    @xavier.seignard: The array should work as well and is far more secure. – choroba Apr 19 '13 at 13:36
  • I second the recommendation for the array option -- `eval` has a tendency to create as many problems as it solves, but arrays work solidly for this sort of thing. – Gordon Davisson Apr 19 '13 at 14:45
  • The fact is that I quickly tried, but without success, I should try again : https://gist.github.com/xseignard/5420661 – xavier.seignard Apr 20 '13 at 10:54