Unable to get major version number of product?

Question

I have code to retrieve the Major versions of a product. Declared a property as PRODVER_MAJOR = 2 Code is as follows:

function myfunction(hMSI)
    string svmajorversion;
    number nsize;
begin
    nsize = 256;
    MsiGetProperty (ISMSI_HANDLE, "PRODVER_MAJOR", svmajorversion, nsize);
    MessageBox ("MajorVersion:" +svmajorversion, INFORMATION);
end

score 0 · Answer 1 · answered Apr 19 '13 at 12:34

0

The behavior depends on the scheduling of the action. If this is called from a deferred custom action, it cannot access most properties directly, and instead must retrieve data through the property CustomActionData which in turn must have been set up before calling the action.

In either case, I would recommend replacing the use of ISMSI_HANDLE (a generic global handle primarily useful during events) with hMSI (the handle specifically passed to this custom action).

answered Apr 19 '13 at 12:34

Michael Urman

15,737
2
28
44

@Micheal Uman If I want to make this work out what are the changes that I need to do in case of deferred custom action? Please update the same code. – user2256852 Apr 22 '13 at 08:32
The custom action is in commit execution mode – user2256852 Apr 22 '13 at 08:57

score 0 · Answer 2 · answered Apr 19 '13 at 13:20

It might help to actually check the return value of MsiGetProperty function.

Return value ERROR_INVALID_HANDLE An invalid or inactive handle was supplied.

ERROR_INVALID_PARAMETER
An invalid parameter was passed to the function.

ERROR_MORE_DATA
The provided buffer was too small to hold the entire value.

ERROR_SUCCESS
The function succeeded.

Unable to get major version number of product?

2 Answers2