1

The sonar documentation shows the following as a refactored code of LCOM4 = 1. But it seems to me that it should be 2, because there is no cohesion between getFullName and getFullAddress. What am I missing?

public class Client {

  public String firstname;
  public String lastname;
  public Address address;

  public String getFullName() {
    return firstname + " " + lastname;
  }

  public String getFullAddress() {
    return address.getFullAddress();
  }

}
Miserable Variable
  • 28,432
  • 15
  • 72
  • 133

1 Answers1

2

Seems you've found a documentation issue! According to Freddy Mallet, this isn't a great example of LCOM4 refactoring and will be fixed:

http://sonar.15.n6.nabble.com/Question-about-LCOM4-td5009876.html

Generally speaking, there are a handful of data structures that don't fit well into the LCOM4 algorithm, which is important to remember when making refactoring decisions. POJOs and concrete implementations of Template Method pattern are two examples that I have found to fall into this category.

In this specific case Mallet in the above link explains that this specific bean is granted LCOM4=1 because getFullAddress is considered a bean accessor, and bean accessors are excluded from the LCOM4 scoring.

jzheaux
  • 7,042
  • 3
  • 22
  • 36
  • Seems Nicolas Garcin [asked](http://sonar.15.n6.nabble.com/Question-about-LCOM4-td5009876.html) the exact same question couple of days back :) If you can please except the logic from the answer there, that bean accessors are ignored, I can accept your answer. T – Miserable Variable Apr 05 '13 at 23:13
  • @MiserableVariable, is that the info you needed? – jzheaux Apr 06 '13 at 02:10