c# FTP File Download Times out

Question

I am downloading a file from my FTP Server. When it gets to the last bytes it freezes and times out. I had to set the timeout to -1 so it won't time out but the last bytes never finish.

Any ideas?

      FtpWebRequest request = (FtpWebRequest)WebRequest.Create("ftp://xxx" + "/" + fileDownload);
            request.Credentials = new NetworkCredential("xxx", "xxx");
            request.UseBinary = true;
            request.KeepAlive = true;

            request.Timeout = -1;
            request.Method = WebRequestMethods.Ftp.DownloadFile;
            FtpWebResponse response = (FtpWebResponse)request.GetResponse();

            Stream responseStream = response.GetResponseStream();
            FileStream writer = File.Create(@"c:\temp\" + Path.GetFileNameWithoutExtension(fileDownload) + ".csv");


            long length = response.ContentLength;
            int bufferSize = 2048;
            int readCount;
            byte[] buffer = new byte[2048];

           // readCount = responseStream.Read(buffer, 0, bufferSize);

            while (responseStream.CanRead)
            {
                readCount = responseStream.Read(buffer, 0, bufferSize);
                writer.Write(buffer, 0, readCount);

            }     
            responseStream.Close();
            response.Close();

            writer.Close();

score 0 · Answer 1 · answered Apr 03 '13 at 00:58

0

CanRead does not do what you think it does. It just indicates whether a stream can in fact be read from at all. Not whether there are any remaining bytes. Instead rewrite your loop like this:

for (int readCount; (readCount = responseStream.Read(buffer, 0, bufferSize)) > 0;) 
{ 
    writer.Write(buffer, 0, readCount); 
}

answered Apr 03 '13 at 00:58

Kirk Woll

76,112
22
180
195

Trying it now. I got done using Filezilla and i'm missing about 3000 bytes. I hope it works. thanks. – Andre DeMattia Apr 03 '13 at 01:00
Also, unless you really need to buffer. you can simply do `responseStream.CopyTo(writer);` – tidwall Apr 03 '13 at 01:07
@jojaba, yes, good advice. (assuming the OP is using .Net >= 4) – Kirk Woll Apr 03 '13 at 01:07
I have no need for a buffer. can you show an example? using .Net 4.5 – Andre DeMattia Apr 03 '13 at 01:12
@AndreDeMattia, jojaba already posted a complete example. (yes it really is that concise) – Kirk Woll Apr 03 '13 at 01:16
cool, the file still freezes with just about 3000 bytes left. trying it without a buffer now – Andre DeMattia Apr 03 '13 at 01:17
Still freezing up at the same place. This happens to a lot of files on the ftp server. Could it be the FTP server that has the issue? Filezilla works. – Andre DeMattia Apr 03 '13 at 01:39
If it's freezing up with `.CopyTo` then it's definitely not your code that's a problem. – Kirk Woll Apr 03 '13 at 01:42
its about 150 bytes short and it's just sitting there. I am using .CopyTo :/ – Andre DeMattia Apr 03 '13 at 01:44
@AndreDeMattia, have you considered disabling your anti-virus (if any)? I know that's solved this sort of problem for me before. – Kirk Woll Apr 03 '13 at 01:46
I'll try that now. File is 80 mg so it takes a half hour to dl. – Andre DeMattia Apr 03 '13 at 01:48
same thing. -365 bytes short. It's still sitting like it's downloading the file. I set the timeout to -1 because it would time out before. Some files download others don't. odd.. – Andre DeMattia Apr 03 '13 at 02:07

c# FTP File Download Times out

1 Answers1