0

I'm trying to join an old piece of code in C to my present VC++ project:

// .h
    class DMSinv : public CDialog {
        double finte(double z);
        double ITFStolz(double Zp1, double Zp2, double Zc);
    };

// .cpp
    double Zcglob;
    double DMSinv::finte(double z) 
    {
       return TFStolz(z, Zcglob);
    }

    double DMSinv::ITFStolz(double Zp1, double Zp2, double Zc)
    {
        int ierr;
        Zcglob = Zc;

        return (coteglob(&DMSinv::finte, Zp1, Zp2, 1.0e-10, &ierr));
    //error C2664: 'DMSinv::coteglob' : cannot convert parameter 1 from 'double (__thiscall DMSinv::* )(double)' to 'double (__cdecl *)(double)'    

    }

the coteglob function comes from the old C part, and finte is a intermediate function to pass the TFStolz function to coteglob.

I've searched in the forums and found this related question: How to convert void (__thiscall MyClass::* )(void *) to void (__cdecl *)(void *) pointer which I tried to apply in this way:

// .h
    class DMSinv : public CDialog {
        virtual double finte(double z);
        double ITFStolz(double Zp1, double Zp2, double Zc);
    };

// .cpp
    double Zcglob;
    extern "C"
    {
        static double __cdecl finteHelper(double z)
        {
            DMSinv* datainv = reinterpret_cast< DMSinv > (z); //error C2440: 'reinterpret_cast' : cannot convert from 'double' to 'DMSinv'  

            datainv->finte(z);
        }
    }

    double DMSinv::ITFStolz(double Zp1, double Zp2, double Zc)
    {
        int ierr;
        Zcglob = Zc;
        double solution = coteglob(&finteHelper, Zp1, Zp2, 1.0e-10, &ierr);
        return solution;
    }

but is still not working. Can somebody guide me on how to adapt it? I'm quite a newbie yet and this seems far from my knowledge.

Thanks in advance!

Community
  • 1
  • 1
madoro
  • 55
  • 7

2 Answers2

0

I don't think you can do it this way. You need to somehow pass the reference to your object (this). In the linked question the parameter to the function was defined as type void * thus you could pass whatever you need to the function, including pointer to this. Your function accepts double, so you can't pass this to it.

I think the easiest would be to define your intermediate function out of class, since it appears to be independent of class internals. Something like this:

double finte(double z) 
{
   return TFStolz(z, Zcglob);
}

You can also store the instance pointer in a public global/static in-class variable that the static function can read.

SomeWittyUsername
  • 18,025
  • 3
  • 42
  • 85
  • This seemed a simple and clean solution, but TFStolz is a funtion of the class DMSinv, so if when finte is out of class, it doesn´t recognise TFStolz:`error C3861: 'TFStolz': identifier not found`. Maybe with pointers in finte to include TFStolz... I have to re-think it, as I said I'm a newbie and don´t have ease with this issues. Thanks! – madoro Mar 27 '13 at 12:50
0

Not sure it is possible to do as you want. Only option that comes to my mind is to use some static variable to store address of DMSinv object. This limits you to 1 thread with simple implementation...

Try this:

// .h
class DMSinv : public CDialog {
    double finte(double z);
    double ITFStolz(double Zp1, double Zp2, double Zc);

private:
  static DMSinv* _current;
  static double __cdecl finteHelper(double z);
};

// .cpp
double Zcglob;
DMSinv* DMSinv::_current = 0;
double DMSinv::finte(double z) 
{
   return TFStolz(z, Zcglob);
}

double DMSinv::ITFStolz(double Zp1, double Zp2, double Zc)
{
    int ierr;
    Zcglob = Zc;

   _current = this;
   return (coteglob(DMSinv::finteHelper, Zp1, Zp2, 1.0e-10, &ierr));
}

double __cdecl DMSinv::finteHelper(double z)
{
    return _current->finte(z);
}

This is not good solution IMO, but I'm not sure that there is other way.

PS To remove limit of one thread you can use TLS slots or in VC++ just __declspec(thread). With latter just add __declspec(thread) to _current like this: static __declspec(thread) DMSinv* _current;. BUT!!! be aware of that number of per-thread variables is limited for process. Read more on this in MSDN.

UPDATE

Disclamer: Just for fun.

Theoretically, there is other opportunity. You can store assembly code in array, attached to object. This assembly code should be a __cdecl function that simply translates __cdecl to __thiscall based on eip register. But this should never be done though... :D

denis-bu
  • 3,426
  • 1
  • 17
  • 11
  • Why is it asking me for a value in return in finiteHelper, is it necesary when is a static? `error C4716: 'DMSinv::finteHelper' : must return a value`. Thanks for the `__declspec(thread)`, looks interesting, I will have a look. – madoro Mar 27 '13 at 12:56
  • I've update my code to fix this error. Simply add return as, compiler ask you. – denis-bu Mar 27 '13 at 12:59
  • OK, thanks, now it compiles, but is not running, breaks at some point. I'll keep researching why is this happening, as you said it may be not the best solution, but thanks for the help!! – madoro Mar 27 '13 at 13:08
  • I've update my code again. Looks like you just got NULL pointer access here. Moved _current assignment to other function. One more caution though. If call to coteglob is async (i.e. it will return some time after while your main thread is running) you got troubles. You need to wait until this coteglob invoke callback to be able to use finiteHelper for other instance of DMSinv. – denis-bu Mar 27 '13 at 13:18
  • Thank you very much, denis-bu, for your help and explanations to make it more understainable, this was really out of my scope, and sorry for the delay on answering, I was on a travel – madoro Apr 01 '13 at 11:02