Exception thrown by target of invocation in BackgroundWorker

Question

I have the following code:

public void extractZipFile()
{
    if (!System.IO.Directory.Exists(extractDirectory))
        System.IO.Directory.CreateDirectory(extractDirectory);

    BackgroundWorker worker = new BackgroundWorker();
    worker.WorkerReportsProgress = true;
    worker.ProgressChanged += (o, e) =>
    {
        progbarExtract.Value = Convert.ToInt32(e.ProgressPercentage);
    };

    lblExtracting.Text = "Extracting...";
    worker.DoWork += (o, e) =>
    {
        using (ZipFile zip = ZipFile.Read(zipFile))
        {
            int step = Convert.ToInt32(zip.Count / 100.0); 
            int percentComplete = 0; 
            foreach (ZipEntry file in zip)
            {
                file.Extract(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData) + "\\XBMC Library Importer\\XBMC_Files", ExtractExistingFileAction.OverwriteSilently);
                    percentComplete += step; //When I comment this out I don't get an exception
                    worker.ReportProgress(percentComplete);
            }
        }
    };

    worker.RunWorkerAsync();
}

I don't understand why the statement percentComplete += step; causes an error (Exception has been thrown by the target of an invocation.).

How could I fix this?

Also, does anybody knows how could I display a message box (MessageBox.Show()) when extraction is complete?

Any help would be appreciated.

score 6 · Accepted Answer · answered Mar 25 '13 at 01:36

6

You'll need to look at the exception's InnerException property to know the cause of the TargetInvocationException.

Taking a rough guess at it: you calculate the value of step incorrectly. It should be 100.0 / zip.Count. Should be a double as well. So you'll risk incrementing progress past 100 when the .zip file contains more than 100 files. And that will bomb when you assign that value to ProgressBar.Value. You should have noticed the progress bar misbehaving as well on small archives, never incrementing at all.

A good way to debug elusive bugs like this is Debug + Exception, tick the Thrown checkbox for CLR exceptions. The debugger will now stop when the exception is thrown.

answered Mar 25 '13 at 01:36

Hans Passant

922,412
146
1,693
2,536

It breaks at `Application.Run(new MainWindow());` in Program.cs – davidweitzenfeld Mar 25 '13 at 01:39
Oh, sorry, it's actually not there. It breaks at `progbarExtract.Value = Convert.ToInt32(e.ProgressPercentage);` – davidweitzenfeld Mar 25 '13 at 01:44
Right, that's what I guessed. Note that ProgressPercentage is larger than 100. I explained why, your step value is wrong. – Hans Passant Mar 25 '13 at 02:15

score 0 · Answer 2 · answered Mar 25 '13 at 00:56

0

 worker.ProgressChanged += (o, e) =>
    {

// looks like you are tying to update the GUI element from background thread and it is throwing exception. Try marshalling thread to GUI thread.

progbarExtract.Value = Convert.ToInt32(e.ProgressPercentage);
    };

answered Mar 25 '13 at 00:56

mchicago

780
9
21

I'm pretty sure that the `ProgressChanged` handler is invoked on the original GUI thread anyway. – LukeH Mar 25 '13 at 01:09

Exception thrown by target of invocation in BackgroundWorker

2 Answers2