Avoid hardcoded strings in UrlHelper.Action and ModelState.AddModelError

Question

I have the following code-lines:

return Json(new { redirectTo = UrlHelper.Action("Index", "Home") });

and

ModelState.AddModelError("Useraccount.Email", emailAlreadyExistsException.Message);

For both the UrlHelper.Action method and the ModelState.AddModelError Method I'd like to avoid the hardcoded strings. Is there a better possibility?

I hoped that I could use something like a RedirectToRouteResult for the UrlHelper.Action. — mosquito87, Mar 21 '13 at 15:02

score 1 · Answer 1 · answered Mar 21 '13 at 14:49

You could create a constants file and use constants instead:

public static class Constants 
{
    public const string HomeController = "Home";
    public const string IndexAction = "Index";
    public const string UserAccountEmail = "Useraccount.Email";
}

Your code then becomes:

return Json(new { redirectTo = UrlHelper.Action(Constants.IndexAction, Constants.HomeController) });

and

ModelState.AddModelError(Constants.UserAccountEmail, emailAlreadyExistsException.Message);

As an alternative for validation, you could use a library like FluentValidation

Avoid hardcoded strings in UrlHelper.Action and ModelState.AddModelError

1 Answers1