when switching intents I lose data

Question

When switching intents I lose data from the previous onActivityResult I need it to keep both numbers it gets from the user, currently it will keep one number, then when the next is entered it loses the previous, here's code:

package com.eric.theworks;

import android.os.Bundle;
import android.app.Activity;
import android.content.Intent;
import android.view.Menu;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.TextView;

public class MainActivity extends Activity implements OnClickListener {

Button width, height, calc;
TextView area;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    width = (Button) findViewById(R.id.button1);
    height = (Button) findViewById(R.id.button2);
    calc = (Button) findViewById(R.id.button3);
    area = (TextView) findViewById(R.id.textView1);

    width.setOnClickListener(this);
    height.setOnClickListener(this);
    calc.setOnClickListener(this);
}

@Override
public void onClick(View v) {
    // TODO Auto-generated method stub
    Intent i = new Intent(this, Numbers.class);
    switch (v.getId()) {

    case R.id.button1:
        // width
        i.putExtra("numbers", "width");
        startActivityForResult(i, 1);

        break;

    case R.id.button2:
        // height
        i.putExtra("numbers", "height");
        startActivityForResult(i, 1);

        break;

    case R.id.button3:
        // calc

        break;

    }


    }

@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    // TODO Auto-generated method stub
    super.onActivityResult(requestCode, resultCode, data);
    if (data.getExtras().containsKey("widthInfo")){
        width.setText(data.getStringExtra("widthInfo"));

}
    if (data.getExtras().containsKey("heightInfo")){
        height.setText(data.getStringExtra("heightInfo"));

}

}

}





package com.eric.theworks;

import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.EditText;

public class Numbers extends Activity implements OnClickListener {
EditText number;
Button sendInfo;

@Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.numbers);
    number = (EditText) findViewById(R.id.editText1);
    sendInfo = (Button) findViewById(R.id.button1);
    sendInfo.setOnClickListener(this);
}

@Override
public void onClick(View v) {
    // TODO Auto-generated method stub
    String s = number.getText().toString();
    Intent i = getIntent();
    String msg = i.getStringExtra("numbers");
    if (msg.contentEquals("width")) {
        i.putExtra("widthInfo", s);
        setResult(RESULT_OK, i);
        finish();

    }
    if (msg.contentEquals("height")) {
        i.putExtra("heightInfo", s);
        setResult(RESULT_OK, i);
        finish();

    }

    }

}

KDeogharkar · Accepted Answer · 2013-03-16T05:21:06.900

1

You can use static variable to store the previous data.

Declare static string globally.

static String widthInfo="";
static String heightInfo="";

Also Give different Requestcode.

case R.id.button1:
        // width
        i.putExtra("numbers", "width");
        startActivityForResult(i, 1);

        break;

    case R.id.button2:
        // height
        i.putExtra("numbers", "height");
        startActivityForResult(i, 2);

Then use it in your onActivityResult.

 @Override
    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
        // TODO Auto-generated method stub
        super.onActivityResult(requestCode, resultCode, data);
         switch (requestCode) {
        case (1): {

        if (data.getExtras().containsKey("widthInfo")){
            widthInfo=data.getStringExtra("widthInfo")
            width.setText(data.getStringExtra("widthInfo"));

    } else {
    height.setText(heightInfo);
    width.setText(widthInfo);
    }
        }
   break;
       case (2): 
        {
        if (data.getExtras().containsKey("heightInfo")){
            heightInfo=data.getStringExtra("heightInfo")
            height.setText(data.getStringExtra("heightInfo"));

    }else {
    height.setText(heightInfo);
    width.setText(widthInfo);
    }

    }
   break;
    }
}

edited Mar 16 '13 at 05:21

answered Mar 15 '13 at 07:14

KDeogharkar

10,939
7
51
95

1

This method does work, but for some reason it gets rid of the text on button 2 and makes it blank (tho can still be used), as of right now they but just say "button", but that would change eventually. – Eric Miller Mar 15 '13 at 09:45
you can do one thing. put the resultCode different 1 for width and 2 for height let say then in activityResult separate above code according to resultCode. switch(ResultCode){case 1: {// code of width break;} case 2: { // code of height. break;}} – KDeogharkar Mar 15 '13 at 09:51
Same issue.... it is strange as Tutorial I watched guy coded it the original way and showed himself running it and everything and it worked fine. Heres link: http://www.youtube.com/watch?v=03uml_haPH0&list=SP667C75EE599C22C6 – Eric Miller Mar 16 '13 at 05:12
Ok very strange, the program works on a avd but not my actual device lol? – Eric Miller Mar 16 '13 at 05:26
whats different in your edited version anyway maybe im missing somthing? I tryed the =""; – Eric Miller Mar 16 '13 at 05:33
check else condition for both cases you will find the difference – KDeogharkar Mar 16 '13 at 05:34
and I declare the string with empty "". – KDeogharkar Mar 16 '13 at 05:35
Only works in the avd, on phone the other button goes back to saying "Button". – Eric Miller Mar 16 '13 at 05:37
I dont get the meaning saying "Button". – KDeogharkar Mar 16 '13 at 05:39
I lose the height or the width, and it goes back to default. – Eric Miller Mar 16 '13 at 05:40
ok but just try the new edition that i just put and than if it is not work i will look into other alternatives. – KDeogharkar Mar 16 '13 at 05:42
No, same result.... Since it works in avd would it prob work on most phones just not mine lol? – Eric Miller Mar 16 '13 at 05:48
Phone is 4.1.1 verizon galaxy nexus. let me try using a emulated avd and see if it has same result. – Eric Miller Mar 16 '13 at 05:51
Seems you cannot make a 4.1.1 avd? – Eric Miller Mar 16 '13 at 05:52
you can also use shared preference as another alternative – KDeogharkar Mar 16 '13 at 06:01
Thank you very much for your help, but since this whole app is just for learning purposes I think I will just test it on the avd. Sorry to take up so much of your time. – Eric Miller Mar 16 '13 at 06:02
its my pleasure .. we must always in a learning curve .. you can upvote answer if you find it useful. – KDeogharkar Mar 16 '13 at 06:03
Would if i had the rep sorry :( Maybe ill have it soon. – Eric Miller Mar 16 '13 at 06:05
and try to use shared preference instead of static variable. if that work thats fine and if it is not work you will learn about shared preferences instead. – KDeogharkar Mar 16 '13 at 06:05
So I have found information, seems it is a bug with galaxy nexus and onActivityResult and getIntent: http://stackoverflow.com/questions/14354081/galaxy-nexus-intent-action-pick-bug-on-jelly-bean-4-1-1 – Eric Miller Mar 16 '13 at 06:08

score 0 · Answer 2 · answered Mar 15 '13 at 07:13

you can use Bundle to pass data from one activity to another rather than the intent directly. for example:

 Bundle b = new Bundle();
        b.putString("SingleClick",a );
        b.putString("LongClick", "no");
        i.putExtras(b);

and to get the data in another activity use

Bundle bundle = getIntent().getExtras();
        String admin = bundle.getString("LongClick");

score 0 · Answer 3 · answered Mar 15 '13 at 07:27

0

String s = number.getText().toString();
Intent i = getIntent();
String msg = i.getStringExtra("numbers");
if (msg.contentEquals("width")) {
    i.putExtra("widthInfo", s);
    setResult(RESULT_OK, i);
    finish();

}

make sure the string s has any values....

answered Mar 15 '13 at 07:27

kalandar

793
6
13

What do you mean? It gets text from the edit field in .Numbers. It does work and return the string but the issue is when I change heightInfo the the widthInfo just goes back to saying "button", where I need to keep both strings. – Eric Miller Mar 15 '13 at 09:48

when switching intents I lose data

3 Answers3