django 1.5 admin inline extra

Question

I have some models with a large number of inlines. Since not all are needed for every object I declared the inline model with extra = 0 so that a small add + appeared on the inline.

However, this seems to no longer work in django 1.5. If extra = 0 is set, the inline is no longer editable.

Is there a way to get the 1.4 behavior into 1.5?

Example Code:

class ModelInline(admin.StackedInline):
    model = MyModel
    extra = 0

class OtherModelAdmin(admin.ModelAdmin)
    inlines = [ModelInline]

admin.site.register(OtherModel, OtherModelAdmin)

Edit (some screens):

Django 1.4: django 1.4 extra=0

Django 1.5: enter image description here

(Hinzufügen == add)

Example code would be good to see here. – Andrew Sledge Mar 13 '13 at 12:31 — Andrew Sledge, Mar 13 '13 at 12:31

score 8 · Accepted Answer · answered Mar 16 '13 at 13:55

8

This is already happen before.

The new javascript made this impossible because the "Add Another" button 
was controlled by max_num, and ignored a value of 0.
The javascript ignored a value of 0 because max_num has a default value of 0, 
and all the code using it had taken to equating max_num = 0 with being "off". 
So you can't actually have a maximum of 0. It's not possible.

There is a patch create by Gabrial Hurley to restores desired behaviour without breaking anything else. This is 3years ago and I don't know if it still working for Django 1.5. Just try :)

https://code.djangoproject.com/attachment/ticket/13023/13023_inlines_patch.diff

Here is the ticket for that same bug (3 years ago):

https://code.djangoproject.com/ticket/13023

answered Mar 16 '13 at 13:55

catherine

22,492
12
61
85

I can't seem to apply this in 1.6 because total_form_count is no longer defined in models.py, only in formsets.py, and the code is different, so I'm not sure what to change. Can anyone help? – smwilsonau Oct 10 '14 at 22:39
@smwilsonau In Django 1.6, it is called `initial_form_count` – catherine Oct 11 '14 at 10:49
thanks, I found the equivalent lines and applied the patch, but my problem turned out to be something different... – smwilsonau Oct 11 '14 at 18:09

score 2 · Answer 2 · answered Mar 18 '13 at 16:51

2

I ran into the same issue because I had the static admin content in a directory that was outside of django's install. Copying the Django 1.5 static content from django/contrib/admin/static/admin/js/ to STATIC_ROOT/admin/js fixed the issue.

answered Mar 18 '13 at 16:51

Kevin Klaes

29
2

1

That's actually not a good thing to do. When you upgrade django version at some point, you'll run into trouble cause you won't see the new version of those static files (just had such an issue). If you server static content the proper way (https://docs.djangoproject.com/en/dev/howto/static-files/) you should have no problem – nivcaner May 07 '14 at 13:21

score 0 · Answer 3 · answered Apr 19 '17 at 11:33

0

the better solution would be to override the get_extra method of the inline itself. This works in Django 1.9, though i cannot say for earlier versions

answered Apr 19 '17 at 11:33

xgadam

180
1
11

Omid Ostovari · Answer 4 · 2021-04-03T11:43:09.573

All you have to do is add extra field.

For Example:

models.py:


class Category(models.Model):
    name = models.CharField(max_length=50)
    def __str__(self):
        return self.name


class Product(models.Model):
    name = models.CharField(max_length=50)
    price = models.IntegerField()
    category = models.ForeignKey(Category, on_delete=models.CASCADE)

    def __str__(self):
        return '{}, {}'.format(self.name, self.company)

admin.py:

    class InlinesProduct(admin.StackedInline):
        model = Product
        extra = 0     #<=== For remove empty fields from admin view

    @admin.register(Category)
    class CategoryAdmin(admin.ModelAdmin):
        inlines = [InlinesProduct]

score 0 · Answer 5 · answered Jun 21 '22 at 17:09

Use "get_extra()" as shown below if "extra" field doesn't work:

class ModelInline(admin.StackedInline):
    model = MyModel
    # extra = 0

    def get_extra(self, request, obj=None, **kwargs):
        return 0 # Is equivalent to "extra = 0"
    
class OtherModelAdmin(admin.ModelAdmin)
    inlines = [ModelInline]
    
admin.site.register(OtherModel, OtherModelAdmin)

django 1.5 admin inline extra

5 Answers5