Code calls terminate instead of throwing exception

Question

I want to throw an exception like this:

if (...) {  
    throw "not found";  
}

and catch it like this:

try {  
    myfunction();  
} catch (const char * msg) {  
    cout << msg << endl;  
}

but then it says

terminate called after throwing an instance of 'char const*'

Why does it call terminate and not throw my "not found"?

EDIT:

I changed it to this:

try {
    throw "not found";
} catch (const char * msg) {
    cout << "test" << endl;
} catch(...) {
    cout << "test" << endl;
}

and I get the same error!

EDIT2: When I don't call a specific method above, it works! But I don't understand what this method has to do with exceptions, I didn't use it in any other function than the above mentioned myfunction(). Let me test some more and then I will get back to you!

EDIT3:

Oh my, this is embarrassing. Looks like I called the wrong function. I am so so sorry to have bothered you with this shameful experience!

Sorry guys, I saw the `const` wasn't in the same place and got confused by `const` vs `const *` vs whatever Scott Meyers talks about knowing the difference between. — ta.speot.is, Feb 24 '13 at 00:05
@BastianMattes http://liveworkspace.org/code/3Z0gVd$8 <- works for me. Are you possibly calling `myfunction()` outisde of a `try` block before you even reach your `try`? — us2012, Feb 24 '13 at 00:08
I think your if (...) is the thrower not your `throw "not found"` — thiagoh, Feb 24 '13 at 00:09
http://stackoverflow.com/questions/6208565/const-char-vs-char-c looks like you're probably doing catch(char* msg) but are telling us that you're doing catch(const char* msg) — thang, Feb 24 '13 at 00:11
Sorry for not answering sooner, somehow I never got an email that this questions got answered. — gartenriese, Feb 26 '13 at 11:28
@AndyProwl: This is now my real code. (@Cheers and hth. - Alf) — gartenriese, Feb 26 '13 at 11:31
sidenote: You should always use exceptions derived (directly or indirectly) from `std::exception`, so that your clients can at least catch upon that. — Sebastian Mach, Feb 26 '13 at 11:36

score 1 · Accepted Answer · answered Feb 24 '13 at 00:33

1

If you use throw outside of a try/catch block, terminate gets called. Make sure the function that throws is in the try block.

#include <iostream>

void myFunc()
{
    throw "Throwing!";
}

int main()
{
    try
    {
        myFunc();
    }
    catch(...)
    {
        std::cout << "Works fine.";
    }

    myFunc(); // Terminate gets called.

    return 0;

}

answered Feb 24 '13 at 00:33

SiimKallas

934
11
23

See my edit above, I am definitely throwing inside the try block. – gartenriese Feb 26 '13 at 11:37

Code calls terminate instead of throwing exception

1 Answers1