What am I doing wrong

Question

I have been struggling with this for a week or two now, and I just cant seem to resolve it. Here is my Script:

<?php
$Domain = $_SERVER['SERVER_NAME'];
$paryDomain = explode(".",$Domain);
$Array = count($paryDomain);
$RootDomain = "";
$G_SYSTEMID = "";

if ($Array == "1")
{
    $RootDomain = $paryDomain[0].'.'.$paryDomain[1];
}    
elseif ($Array == "2")
{
    $RootDomain = $paryDomain[1].'.'.$paryDomain[2];
}

if ($RootDomain == "storeboard.com")
{
    $G_SYSTEMID = 1;
}
elseif ($RootDomain == "dcwn.org")
{
    $G_SYSTEMID = 2;
}

echo $G_SYSTEMID;
echo "------------";

?>

Why do I get no result at the end either 1 or 2..?

Any help would be greatly appreciated.

Neojakey

I would say the obvious cause is that $RootDomain is neither of the strings you compare it too... Maybe you can echo it and see what the actual value is...? — MrHug, Feb 22 '13 at 21:47
Start echoing out variables at various points throughout the logic and see where they start not being what you're expecting. — ceejayoz, Feb 22 '13 at 21:47
Maybe you should check as INTEGER not as STRING... `$Array == "1"` is string due to `$Array == 1` is INTEGER. If you `count($var);` you will get result as INTEGER. — Marin Sagovac, Feb 22 '13 at 21:48
Use var_dump($paryDomain) to see the content of your explode operation, that could help. Other thing, try using strcmp to compare strings http://php.net/manual/en/function.strcmp.php — legrandviking, Feb 22 '13 at 21:49
Many thanks for all your help, and my apologies for the inappropriate title.. — neojakey, Feb 22 '13 at 22:23

Sir · Accepted Answer · 2013-02-22T21:59:32.793

2

if ($Array == 1)
{
    $RootDomain = $paryDomain[0]; 
}    
elseif ($Array == 2)
{
    $RootDomain = $paryDomain[0].'.'.$paryDomain[1];
}    
elseif ($Array == 3)
{
    $RootDomain = $paryDomain[1].'.'.$paryDomain[2];
} else {
    //to debug the possible cause 
    $G_SYSTEMID = 'Array length was equal to '.$Array;
    $RootDomain = false;
}

You had your array count not matching the pointers you were using this should help. You were also checking for strings instead of integers...

edited Feb 22 '13 at 21:59

answered Feb 22 '13 at 21:51

Sir

8,135
17
83
146

I made this change an still got no output from the script.. Any other suggestions..? – neojakey Feb 22 '13 at 21:54
@neojakey see edit :) you had to use count function to count array length and you had the array pointer numbers incorrect :) arrays start at `0` – Sir Feb 22 '13 at 21:54
@neojakey third edit ive added an extra if to take into account all options – Sir Feb 22 '13 at 22:00
+1 Dave that is true, I also explained it in detail – Feb 22 '13 at 22:06

score 1 · Answer 2 · 2013-02-22T22:09:27.073

$Array = count($paryDomain);
if ($Array == "1")
{
    $RootDomain = $paryDomain[0].'.'.$paryDomain[1];
}

if $Array contains one element then $paryDomain[1] is not exist, or the array must contain only one element.

for whose that says about $Array that is integer:

$Array = 1;
var_dump(($Array == "1"));
var_dump(($Array == "2"));

bool(true) 

bool(false)

WHAT IS WRONGS IS: Your server name if any ((www.)?example.com):

if ($Array == "1")
{
    $RootDomain = $paryDomain[0].'.'.$paryDomain[1];
}    
elseif ($Array == "2")
{
    $RootDomain = $paryDomain[1].'.'.$paryDomain[2];
}

Because $paryDomain = explode(".",$Domain); at least contains two element, then, $Array is never equals to one, only in one cases, when SERVER_NAME is one word!

Solution:

if ($Array == "2")
{
    $RootDomain = $paryDomain[0].'.'.$paryDomain[1];
}    
elseif ($Array == "3")
{
    $RootDomain = $paryDomain[1].'.'.$paryDomain[2];
}else{

}

if ($RootDomain == "storeboard.com")
{
    $G_SYSTEMID = 1;
}
elseif ($RootDomain == "dcwn.org")
{
    $G_SYSTEMID = 2;
}else{
//in case when none of above cases true
    $G_SYSTEMID = 100;
}

kittycat · Answer 3 · 2013-02-26T13:15:42.213

1

Just wanted to show you an easier way to do this. It will support domains with unlimited sub-domains as it grabs the last two parts always:

if (strpos($_SERVER['SERVER_NAME'], ".") !== false) {
    preg_match('/(?P<domain>[a-z0-9][a-z0-9\-]{1,63}\.[a-z]+)$/i', $_SERVER['SERVER_NAME'], $item);
    $RootDomain = $item['domain'];
} else {
    $RootDomain = $_SERVER['SERVER_NAME'];
}

switch ($RootDomain)
{
    case 'storeboard.com':
        $G_SYSTEMID = 1;
        break;
    case 'dcwn.org':
        $G_SYSTEMID = 2;
        break;
    default:
        $G_SYSTEMID = '';
        break;
}

echo $G_SYSTEMID;

edited Feb 26 '13 at 13:15

answered Feb 22 '13 at 22:19

kittycat

14,983
9
55
80

1

@Baba should `\.[a-z\.]{2,6})` be changed to `\.[a-z]+)`? I think the period is a typo right? Also this would limit the TLD to 2-6 chars, but ICANN has opened up the [purchase](http://www.techspot.com/news/47031-icann-selling-custom-top-level-domains-for-185000.html) of TLDs so we can have domains like mysite.somefancytld in the future. – kittycat Feb 26 '13 at 13:11
`ICANN selling custom top-level domains for $185,000` wow .. thanks for the information .... you can change it – Baba Feb 26 '13 at 13:12

Stef Geysels · Answer 4 · 2013-02-22T22:21:04.507

0

First echo your $Domain

echo $_SERVER['SERVER_NAME'];

Then print_r your $paryDomain

print_r($paryDomain);

And if these are correct, echo your count()

echo count(explode(".",$_SERVER['SERVER_NAME']));

edited Feb 22 '13 at 22:21

answered Feb 22 '13 at 22:09

Stef Geysels

1,023
11
27

score -1 · Answer 5 · edited Feb 22 '13 at 21:54

-1

$G_SYSTEMID = strstr($_SERVER['SERVER_NAME'], 'storeboard.com') ? 1 : 2;

edited Feb 22 '13 at 21:54

kittycat

14,983
9
55
80

answered Feb 22 '13 at 21:53

slattman

98
6

eh, still like my way better :) – slattman Feb 22 '13 at 22:21
Yeah if you don't care about checking for the other domain `dcwn.org`... – kittycat Feb 22 '13 at 22:23
i only see two options, and even if there were more, it wouldn't be a big deal to add a line for each and default with 0. It's still less writing than using a switch or otherwise. – slattman Feb 22 '13 at 22:53
and btw, if you are going to manipulate the server name and explode it into an array, you should probably make sure there is a period in the server name before you attempt to split it. ie. localhost – slattman Feb 22 '13 at 22:57
good, i'm glad you agree ;) – slattman Feb 23 '13 at 16:59
nick, _Sometimes incompetence is useful. It helps you keep an open mind._ **Roberto Cavalli** – slattman Feb 23 '13 at 22:44
and thanks for welcoming me to the community :) – slattman Feb 23 '13 at 22:53

What am I doing wrong

5 Answers5