Convert ToMoney function not working

Question

Function not working for prefix with 8[any numbers].

input: 970 output:$9.70
input: 870 output:$870
input: 800 output:$800

function toMoney( $val, $symbol = '$', $r = 2 ) {
    $n = $val; 
    $c = is_float($n) ? 1 : number_format( $n , $r );
    $d = '.';
    $t = ',';
    $sign = ( $n < 0 ) ? '-' : '';
    $i = $n = number_format( abs( $n ), $r ); 
    $j = ( ( $j = $i.length ) > 3 ) ? $j % 3 : 0; 

   return  $symbol.$sign .( $j ? substr( $i, 0, $j) + $t : '').preg_replace('/(\d{3})(?=\d)/',"$1" + $t,substr($i,$j)) ;
}

Function taken from: Money conversion not worked

The above error rectified in the below

  function toMoney( $val, $symbol = '$', $r = 2 ) {
        $n = $val; 
        $c = is_float($n) ? 1 : number_format( $n , $r );
        $d = '.';
        $t = ',';
        $sign = ( $n < 0 ) ? '-' : '';
        $i = $n = number_format( abs( $n ), $r ); 
        $j = ( ( $j = strlen($i) ) > 3 ) ? $j % 3 : 0; 

       return  $symbol.$sign .( $j ? substr( $i, 0, $j) + $t : '').preg_replace('/(\d{3})(?=\d)/',"$1" + $t,substr($i,$j)) ;
    }

`$i.length` ? what kind of notation is that in PHP? Also, you are using `+` as string concat operator while you should use `.`, see for example your last line. — Matteo Tassinari, Feb 18 '13 at 07:52
@Sankalp Mishra please double check ur input and output, please tell me your PHP Version. — Bharanikumar, Feb 18 '13 at 09:04
@Matteo Tassinari converted length into strlen($var) and problem fixed — Bharanikumar, Feb 19 '13 at 03:39

score 1 · Accepted Answer · answered Feb 18 '13 at 07:52

If I understand well, you want the two last numbers to be cents?

so why don't just do :

$val = number_format(intval(substr($val,0,strlen($val)-2)),).'.'.substr($val,-2);

the first substr will just forget the two last digits and then will be formated with only thousand separator. the second substr just take the two last numbers.

score 1 · Answer 2 · answered Feb 18 '13 at 09:46

1

setlocale(LC_MONETARY, 'en_US');
echo '$' . money_format('%i', $number/100) . "\n";

answered Feb 18 '13 at 09:46

dave

62,300
5
72
93

Maybe you should also put a few words here, don't just post a code. – partlov Feb 18 '13 at 10:07
+1 for using native PHP functions, without reinventing the wheel – Matteo Tassinari Feb 19 '13 at 08:00

Convert ToMoney function not working

2 Answers2