Create an associative array in php with dynamic key and value

Question

I want to create an associative array in php with dynamic key and also a dynamic value from a particular mysql table.

The table name is monthly_salary with a two column named month and salary respectively.

I get the data inside it:

$sql = mysql_query('SELECT * FROM monthly_salary');
$sql2 = mysql_query('SELECT * FROM monthly_salary');

Then assigned and concatenated the collected data to $mon and $sal:

$mon = "";
$sal = "";
while($row = mysql_fetch_array($sql)){
    $mon .= $row['month'].", ";
}
while($row = mysql_fetch_array($sql2)){
    $sal .= $row['salary'].", ";
}

After that I've converted it to array and concatenate it until it became and associative array:

$monArray = array(substr(trim($mon), 0, -1));
$salArray = array(substr(trim($sal), 0, -1));
$key = "";
$keyWithVal = "";
foreach($monArray  as $k){
    $key .= $k." => ";
}
foreach($salArray  as $k){
    $keyWithVal .= $key.$k.",";
}

$associativeArray = array(substr(trim($keyWithVal), 0, -1));

My Problem is that when I've echo it the result is always like this 3500=>Jan=>3500:

foreach($associativeArray  as $k => $id){
    echo $k."=>".$id;
}

So how can I fix it and with the correct output Jan=>3500?

What do you expect `array(substr(trim($mon), 0, -1))` to do? All this does is convert the string to an array, which gives you an array with one element. `array('1, 2, 3')` doesn't make an array of 3 elements, it makes an array on one element, the string `'1, 2, 3'`. To turn a string into an array, use `explode`. `$array = explode(', ', '1, 2, 3);`. — gen_Eric, Feb 04 '13 at 18:29

score 35 · Accepted Answer · edited Aug 03 '15 at 08:07

35

You are way over-complicating this problem. This can be done simply, with fewer loops.

First, you only need to run the SQL once. Second, build the array in the 1st loop.

$sql = mysql_query('SELECT * FROM monthly_salary');

$associativeArray = array();
while($row = mysql_fetch_array($sql)){
   // Put the values into the array, no other variables needed
   $associativeArray[$row['month']] = $row['salary'];
}

foreach($associativeArray as $k => $id){
    echo $k."=>".$id;
}

edited Aug 03 '15 at 08:07

magicalex

917
7
11

answered Feb 04 '13 at 18:20

gen_Eric

223,194
41
299
337

To show the association, instead of using a loop, you could do echo "
```
"; print_r($associativeArray);
```
– Strixy Feb 04 '13 at 18:22
@Strixy: True, I was just copying the code from the question. – gen_Eric Feb 04 '13 at 18:23

score 6 · Answer 2 · answered Feb 04 '13 at 18:21

6

Why don't you just do:

$associativeArray = array();
while($row = mysql_fetch_array($sql)){
    $associativeArray[$row['month']] = $row['salary'];
}

answered Feb 04 '13 at 18:21

DiscoInfiltrator

1,989
1
18
21

What is the difference between this answer and the one provided by Rocket Hazmat? – nickb Feb 04 '13 at 18:22
5

None, we just posted at the same time. He/she beat me to it. – DiscoInfiltrator Feb 04 '13 at 18:23
6

@DiscoInfiltrator: That's because I'm a ninja ^^ – gen_Eric Feb 04 '13 at 18:25

score 0 · Answer 3 · edited Jan 04 '21 at 08:59

0

Following worked for me for creating associative array. array_push don't work on associative array but using unary operator does work:

$associativeArray += [$key => $value];

edited Jan 04 '21 at 08:59

Hkachhia

4,463
6
41
76

answered Aug 14 '20 at 03:34

srigu

329
1
5
16

Create an associative array in php with dynamic key and value

3 Answers3