Modbus Input via MSComm in Visual C++

Question

I'm completely new to Modbus protocoll. My setup consists of three devices with different addresses. They're all connected to COM1 via RS232. I've used Modbus Poll to check the input-data, which works properly. What I want to do now, is reading the holding registers in a vc++ (MFC) application. For serial communication I use the MSComm class. I have written a little code, but I don't get Input at all.

My code at the moment:

BOOL Crs232test4Dlg::OpenConnection ()
{
    char error [513];

    try
    {
        if (! m_MSComm.GetPortOpen ())
        {
            m_MSComm.SetCommPort (1);
            m_MSComm.SetSettings ("9600,N,8,1");
            m_MSComm.SetInputLen (4);
            // Receive Data as Text
            m_MSComm.SetInputMode (0);
            m_MSComm.SetPortOpen (true);
            m_MSComm.SetCommID (1);
           return m_MSComm.GetPortOpen ();
        }
        AfxMessageBox ("Success!!!!", MB_OK);
        return TRUE;
    }

    catch (CException *e)
    {
        e->GetErrorMessage (error, 512);
        AfxMessageBox (error, MB_OK);
        return FALSE;
    }
}


void Crs232test4Dlg::OnVaisalaComm ()
{
    if (m_MSComm.GetCommEvent () == 2)
    {
        COleVariant in_dat;
        in_dat = m_MSComm.GetInput ();
        Sleep (100);
        CString strInput (in_dat.bstrVal);
        m_Input = m_Input + strInput;
        UpdateData (FALSE);
    }
}

I want to put out m_Input now, but it hasn't changed a bit. I also get the warning (Property is read-only) when setting SetCommID, which I don't think is important.

Can anyone please guide me, since I'm really clueless at the moment.

Regards

EDIT: According to a communication example, I've tried to handle the device like a file.

m_hCom = CreateFile(m_sComPort, 
        GENERIC_READ | GENERIC_WRITE,
        0, // exclusive access
        NULL, // no security
        OPEN_EXISTING,
        0, // no overlapped I/O
        NULL); // null template
// :(colon) Address=1 Function=3 Starting register= 40001 (To write 400001 or 0?)
Registers to read=4 checksum CR LF
char    strASCII[] = "3A 30 31 30 33 30 30 30 30 30 30 30 34 46 38 0D 0A";

bWriteRC = WriteFile (m_hCom, strASCII, strlen(strASCII), &iBytesWritten, NULL);

memset(sBuffer,0,sizeof(sBuffer));
// Reading output of the M3
bReadRC = ReadFile (m_hCom, &sBuffer, 1, &iBytesRead, NULL);

if (bReadRC && iBytesRead > 0)
    {
        sResult = sBuffer;
    }
    else
    {
        sResult = "Read Failed";
        dwError = GetLastError();

        sprintf(sMsg, "Read length failed: RC=%d Bytes read=%d, "
                "Error=%d ",
                bReadRC, iBytesRead, dwError);
        AfxMessageBox(sMsg);
    }

I get the read length failed error. strASCII isn't separated normally, only for better overview now. I have checked the communication in Modbus Poll. My output is right, but it doesn't seem to get the data.

EDIT: I got it. Thank you very much for your help. I had put the wrong checksum.

Are you sure the targeted device operates in ASCII mode ? If so, your string must start with a ":" and end with "\r\n". — Alexandre Vinçon, Feb 07 '13 at 15:38
Additionnaly, "400001" is the nickname for holding register "1". So the starting address in your MODBUS request should be "0" because of the offset in the adressing scheme. — Alexandre Vinçon, Feb 07 '13 at 15:44
I converted the code to hex, as required by Modbus. I have the startinng colon (3A) and the \r\n (0D 0A) included. The address is also converted to 0. According to simplymodbus.ca/ASCII.htm — Andreas D., Feb 08 '13 at 06:38
the starting colon and the final \r\n shall not be converted to hexa representation. Your request should be formatted like this: strASCII[] = ":3031303330303030303030344638\r\n"; — Alexandre Vinçon, Feb 08 '13 at 09:15

score 2 · Answer 1 · answered Nov 12 '15 at 11:41

MODBUS is by far more complex than just reading simple data via the serial port. Is is a complex data packet oriented protocol with complex synchronisation features. It specifies a master and a slave operation. You will not get anything out of a MODBUS device by using MSComm or Hyperterminal. The MODBUS protocol is pretty good documented already but not to that easy to get implemented. Many variations also exists. It will probably require some thousand lines of code to get the basics. A known and mature commercial library is maybe the better approach and this also include technical support, which is essential for this kind of products. For example, SuperCom, a commercial software library that offers MODBUS for serial and TCP data communications and also supports the MFC. Client (Master) and Slave functionality also included. And it offers many samples for well known compilers. There surely exist more commercial solutions there.

Asain Kujovic · Accepted Answer · 2013-02-07T17:36:36.980

1

not an answer, but a guide for trouble shotting.

your best friends should be:

1) null modem 232female<->232female cable with second computer that has com port (or laptop with usb->serial converter) ... soldering cable by your self wire to wire is maybe best solution.

2) windows hyper-terminal simple but reliable application preinstalled on most windows... started in comPort mode, with same bitrate/parity/stopbits parameters that you expect from modules.

first check if connection and cable is ok by running hterm on both comps and 'chat' few sentences
second check if your program ok by running it on first comp, and hterm on other
Modbus modules sometimes do not send anything before Master sends some query on module address, so maybe your program need to send something first (for that investigation you can log your modbusPool with other comp connected instead MBUS-modules)

... with all respects to windows signaling queues and MSCOmm class that is probably ok, but to eliminate all possible reasons for communication failure in project start, maybe you should prefer simple threating COM port as file, and reading from it inside some while loop ... some short version of this example... Setting serial parameters at start and reading file named comX.

above link has good cSerialClass implementation on download, but simple primer without any error checking is here at pastebin .

edited Feb 07 '13 at 17:36

answered Feb 04 '13 at 17:45

Asain Kujovic

1,700
13
19

Thank you for your answer. I'll look into your source and tell you how it went. – Andreas D. Feb 07 '13 at 06:50
[link](http://pastebin.com/Pcc828yy) - not tested with real data but seems ok @AndreasD. – Asain Kujovic Feb 07 '13 at 17:37
I still get no answer. What the heck? CommPort Settings are right. Might it be, that the WriteFile char shouldn't be written in hex? – Andreas D. Feb 08 '13 at 07:03
symplymodbas.ca -> sBuff[] =":1103006B00037E\r\n"; ...sLen==17 @AndreasD. – Asain Kujovic Feb 08 '13 at 08:07
i've converted it for my needs (Address 1, Function 3, Starts at 0, read 4 registers, checksum). char sBuff[] =":01030000000448\r\n"; It still doeesn't work – Andreas D. Feb 08 '13 at 09:20
maybe lrc is 256-(1+3+4)=248=0xF8 ... ':010300000004F8\r\n' but maybe you should try RTU "\x01\x03\x00\x00\x00\x04\xF8\xF8' with crc16 instead of f8f8, or log somehow successuful ModbusPool app @AndreasD. – Asain Kujovic Feb 08 '13 at 10:06
I got it guys: Had put the wrong checksum. I put the string in Hex and in my stupidity left the checksum converted to ASCII. char sBuff[] = ":010300000004F8\r\n"; @Alexandre Vinçon – Andreas D. Feb 08 '13 at 10:10

Alexandre Vinçon · Answer 3 · 2013-02-07T08:59:29.153

Two issues here:

1/ You cannot have three devices connected together with RS232. RS232 is point-to-point, which means only two devices can be connected together.

2/ A slave only sends data when queried by the master. If the master does not send a MODBUS request first, you'll never get a reply from the slaves.

PS: I've got a feeling that m_MSComm.SetCommID() should be called before the port is opended, not after.

In order to create the proper request, you can refer to the standard:

The first document will instruct you how to build the request (PDU), while the second document details how the request must be encapsulated in a "transport" frame (ADU), suitable for the serial communication.

The most common request is "Read Holding Registers" (func. #3). If your slave device has address 5, and you want to read two registers starting at address 10, then your request will look something like: 0x05 0x03 0x000A 0x0002 0x???? (where '????' is the CRC16 value, which I'm too lazy to calculate).

Thank you for your answer. I have one device with three different addresses, by the way. My wording was inaccurate. Do you know by any chance, how to create such a request? — Andreas D., Feb 07 '13 at 06:47
I've tried to handle the device as a file. Please view my edit. @Omer Merdan — Andreas D., Feb 07 '13 at 12:47

Modbus Input via MSComm in Visual C++

3 Answers3