Java Error Returning Password

Question

Possible Duplicate:
Java String.equals versus ==

The main code:

String pass = getPassowrd();
    if(pass == "hi"){
        System.out.println("Correct Password");
        loggedin = true;
        new Home();
    }else{
        System.out.println("Incorrect Password");
    }

The getPassword code:

private static String getPassword() {
    java.util.Scanner keyboard = new java.util.Scanner(System.in);
    return keyboard.nextLine();
}

What am I doing wrong?

Thanks, Isaac

score 2 · Answer 1 · answered Feb 02 '13 at 01:27

2

You are comparing references, use .equals for checking String content, replace

if (pass == "hi") {

with

if (pass.equals("hi")){

answered Feb 02 '13 at 01:27

Reimeus

158,255
15
216
276

score 1 · Answer 2 · answered Feb 02 '13 at 01:28

do a pass.equals("hi") instead of pass == "hi"
With an == operator what you are really comparing are the references, i.e. you are comparing the value in pass which is just an address to the string that it is pointing in the memory and another address that points to the constant string "hi" that is stored in the memory.

With equals you are actually comparing the string "hi" with the string that pass is pointing to in the memory.

Java Error Returning Password

2 Answers2