Indexing an Array - Out of Range

Question

I'm iterating through a string list (storedProcedures) and splitting each list item into an array. I would like to then access the array elements using specific indices. I am getting an out of range exception as soon as I try to access the second element of the array.

string[] myArray = new string[4];
foreach (string procedure in storedProcedures)
{
    myArray = procedure.Split(',');

    foreach (string index in myArray)
    {
        Console.WriteLine(index);
    }

    for (int i = 0; i < myArray.Length; i++)
    {
        Console.WriteLine(myArray[i]);
    }

    Console.WriteLine(myArray[0]);
    Console.WriteLine(myArray[1]);  <---- out of range exception here
    Console.WriteLine(myArray[2]);
    Console.WriteLine(myArray[3]);
}

Accessing the array and printing its contents using the 'foreach' and 'for' loops work fine, so I'm not sure why accessing the array by specifying the indices directly doesn't work?

What is in storedProcedures? It's very possible your myArray contains 1 element. — Nashibukasan, Jan 16 '13 at 02:42

score 3 · Accepted Answer · answered Jan 16 '13 at 02:42

3

This is useless:

string[] myArray = new string[4];

because this throws your array away:

myArray = procedure.Split(',');

Your problem is that one of storedProcedures does not have a comma in it.

answered Jan 16 '13 at 02:42

Dour High Arch

21,513
29
75
90

score 1 · Answer 2 · answered Jan 16 '13 at 02:40

1

What does Console.WriteLine(myArray.Length) show? You start the array out with a size of 4, but procedure.Split(',') gave you a new array, which possible only has one element in it.

answered Jan 16 '13 at 02:40

Matt Greer

60,826
17
123
123

score 1 · Answer 3 · answered Jan 16 '13 at 03:03

Probably your split array is shorter than expected. You should always check for length before retrieving values out of arrays. Maybe some commas are missing, maybe your strings are not properly formatted... debug it better, like so:

foreach (String procedure in storedProcedures)
{
    Console.WriteLine("Current Procedure: \"" + procedure + "\"");

    String[] split = procedure.Split(',');

    Console.WriteLine("Split Length: " + split.Length.ToString());

    for (int i = 0; i < myArray.Length; i++)
        Console.WriteLine(i.ToString() + ") " + split[i]);
}

Thanks! Your code snippet helped me see the problem immediately. I was so hung up on what I thought was code semantics that I missed such an obvious problem. — spickles, Jan 16 '13 at 12:44

Indexing an Array - Out of Range

3 Answers3