Safari fires Backbone route twice

Question

I'm having a headache with Backbone router in Safari

I have this piece of code:

app.navigate("ask/" + encodedSearchKey,true);

and in my router:

var AppRouter = Backbone.Router.extend({

  routes:{
    "":"main",
    "ask/*encodedSearchKey":"askSearch",
  },

  askSearch:function(){
    ...
  },
  ...

});
app = new AppRouter();
Backbone.history.start();

In chrome, it works as expected, the URL gets routed and the askSearch function gets called once

however, in Safari, the askSearch function actually gets executed twice

and when I tried

app.navigate("ask/" + encodedSearchKey,false);

In chrome the askSearch function was not called as expected, but the Safari it actually gets called once

I have run through the debugger and am pretty sure the app.navigate line always gets called once only, and there is nothing else that could fire the askSearch function except the router itself

now I know I can fix this by detecting browser type, but I did not find any similar problems online, it seems that people do not have this issue, am I doing something very wrong here?

What happens when you remove all routes other than askSearch? — hunterloftis, Jan 05 '13 at 16:59

score 1 · Answer 1 · answered Dec 16 '14 at 12:07

I think I've just run across the same issue and found a solution... Safari seems to strip the string from the url for vanity purposes, this then re-triggers the router causing the view to rendered again but lacking the query string data.

The solution I used was fairly simple in the router:

myView: function () {
    if (window.location.search.length) {
        myView.render();
    } else {
        return false;
    }
}

This stops the 2nd render from proceeding. Although this os only really applicable if you only ever want to render that view with a query string.

score 0 · Accepted Answer · answered Jan 06 '13 at 13:41

0

The navigate function's second argument is not a boolean but an option object:

app.navigate("ask/" + encodedSearchKey, {
    trigger: true
});

answered Jan 06 '13 at 13:41

Tal Bereznitskey

2,051
1
20
20

This answer is wrong. You can pass a bool as the second param as a shortcut to set trigger. I don't know why this would be accepted. – DriverDan Aug 16 '13 at 17:23

score 0 · Answer 3 · answered Aug 26 '14 at 08:51

0

in Firefox is the url is not encoded the rout will fire twice, some times...

answered Aug 26 '14 at 08:51

Zeev G

2,191
21
37

Safari fires Backbone route twice

3 Answers3