2

I'm trying to get a pooled JDBC DataSource in my application. I'm writing an open-source library, and want to make configuration as, well, configurable as possible. I'd rather not use JNDI or force the use of any particular type of configuration file.

Right now, I do this:

MysqlConnectionPoolDataSource ds = new MysqlConnectionPoolDataSource();
ds.setDatabaseName("blah");
ds.setUrl("jdbc:mysql://blaggablah");
ds.setUser("jimbob");
ds.setPassword("dweezil");

Obviously not ideal if you want to use something other than MySQL in the future.

Is there some kind of generic PooledDataSourceFactory that will take a few parameters, like database type and connection info, and give me a pooled DataSource?

ccleve
  • 15,239
  • 27
  • 91
  • 157
  • 1
    Why not use a real connection pool (e.g. DBCP, C3P0, Tomcat JDBC pool) which is configured outside of your application (e.g. through JNDI)? –  Jan 01 '13 at 00:31
  • Good idea. Don't want to force anyone to use JNDI, but C3PO and BoneCP look interesting and don't require it. – ccleve Jan 01 '13 at 03:32
  • 1
    None of the mentioned pools "require" JNDI. –  Jan 01 '13 at 08:09
  • Also remember: `ConnectionPoolDataSource` implementations are **no** connection pools themselves, they are factories for physical connections to be used by a `DataSource` implementation that actually provides connection pooling. See also my answer to this question: http://stackoverflow.com/a/12651163/466862 – Mark Rotteveel Jan 01 '13 at 11:58
  • @a_horse_with_no_name Post your "use a real connection pool" suggestion as an answer and I'll accept it. – ccleve Jan 01 '13 at 20:46

2 Answers2

1

I'm not sure what kind of application (library?) you are creating, but unless it's a web app. stack or something, you could ask the client programmer to pass-in the datasource, e.g. via the constructor. This is really the gist of dependency injection.

If you app. is e.g. a web app. stack like Django, you can still make it so that you internally pass a datasource to your middleware (a.k.a DI). Such design facilitates modularity, and makes it easy to use that part of code in other projects. However, you'll have to go from configuration to DataSource somehow, so at some point you need to decide what the mechanism for that will be (e.g. JNDI). I think that's perfectly acceptable.

Enno Shioji
  • 26,542
  • 13
  • 70
  • 109
0

You can use a standard pooling/caching library and let the use configure it. Like Apache Jakarta Pool, or ehcache?

Zagrev
  • 2,000
  • 11
  • 8