How to solve error: expected identifier or '('

Question

I've got a problem with something I'm programming. I get this error over and over;

jharvard@appliance (~/Dropbox/pset1): make mario
clang -ggdb3 -O0 -std=c99 -Wall -Werror    mario.c  -lcs50 -lm -o mario
mario.c:23:5: error: expected identifier or '('
    do
    ^
mario.c:32:1: error: expected identifier or '('
do
^
2 errors generated.

I searched all over the internet but couldn't find the problem.. removing the ; after int main(void) didn't help

This is my code:

#include <stdio.h>
#include <cs50.h>
#include <math.h>

int main(void);

    //Ask User for Height, and check

    int a, b, rows, height;
    int a = 0;
    int b = 0;
    int rows = 1;   

    do
    { 
        printf ("Height: ");
        height = GetInt();
    }
    while (height <=0 || height > 23);   

    //build half pyramid

    do
    {
        do
        {
            printf("r");
            a++;
        }
        while (a < height - rows);

        do
        {
            printf("#");
            b++;
        }
        while (b < rows + 1);


        printf("\n");
        rows++;

        while (rows <= height);
    }

I've been trying to solve this problem for a few days, but i just can't figure it out!

Thank you so much in advance!

Fix your indentation, that last while looks really strange there all alone. — Mat, Dec 23 '12 at 14:14
It's because of missing `}` before `printf` of `while` (depends on the real body cycle, don't know what you really mean because of bad indentation) — maverik, Dec 23 '12 at 14:15
+1 to what @Mat said. The last while look like it should be after the closing bracket (which belongs to the second `do`). But indent your code, and such mistakes will be obvious to you. If you don't indent your code, than you deserve to suffer like that. — StoryTeller - Unslander Monica, Dec 23 '12 at 14:17

score 11 · Answer 1 · answered Dec 23 '12 at 14:17

11

int main(void);

You have just declared the main. You need to define it and add the code inside that definition.

int main()
{
   .....
}

answered Dec 23 '12 at 14:17

Alok Save

202,538
53
430
533

dreadlock · Accepted Answer · 2012-12-23T14:38:13.057

You got nested loop with do/while. Make sure that each start with do end with while.

Look like at the end of file, the "while" is not correct.

printf("\n");
rows++;

while (rows <= height);
}

That could be you missing the close '}' before 'while (rows <= height);'

Correct code could be:

int main(void)
{

    //Ask User for Height, and check

    int a, b, rows, height;
    a = 0;                    // <- removed int
    b = 0;                    // <- removed int
    rows = 1;                 // <- removed int

    do
    { 
        printf ("Height: ");
        height = GetInt();
    }
    while (height <=0 || height > 23);   

    //build half pyramid

    do
    {
        do
        {
            printf("r");
            a++;
        }
        while (a < height - rows);

        do
        {
            printf("#");
            b++;
        }
        while (b < rows + 1);


        printf("\n");
        rows++;
    }                             // <- add }
    while (rows <= height);
}

Blastcore · Answer 3 · 2012-12-23T14:21:48.733

2

Main post is edited, so clear answer.

All your code is outside of a function because you're doing int main(); you're declaring a function. Use {} brackets instead.

int main() {
    //Code here.
}

edited Dec 23 '12 at 14:21

answered Dec 23 '12 at 14:16

Blastcore

360
7
19

He's not. It's at the bottom, or so it seems – StoryTeller - Unslander Monica Dec 23 '12 at 14:16
It's confusing with that indentation. – Blastcore Dec 23 '12 at 14:21

score 2 · Answer 4 · answered Dec 23 '12 at 14:25

2

int a, b, rows, height;
int a = 0;
int b = 0;

Here in your above statements a and b are re-declared more than once causing compilation error.

answered Dec 23 '12 at 14:25

Sunil Bojanapally

12,528
4
33
46

score 1 · Answer 5 · answered Dec 23 '12 at 14:22

1

Take the last while outside of the do scope:

while (rows <= height);

answered Dec 23 '12 at 14:22

Konstantin Dinev

34,219
14
75
100

score 1 · Answer 6 · answered Dec 23 '12 at 16:14

If you don't indent your code, which you (by all means) should do, at least write the starting and the ending curly brackets at once when you write the loop statement, before putting any code into that loop's body (which goes between the curly brackets). It will save you from troubles like these in the future.

score -1 · Answer 7 · answered Jun 04 '21 at 03:57

-1

In case of react native project .... its a simple issue.

You can go to you project target in ios and check Build, version and build identifier... they might have extra space on the end which should be removed

Hope it helps. Worked for me

answered Jun 04 '21 at 03:57

Rahul Shakya

1,269
15
15

How to solve error: expected identifier or '('

7 Answers7

Linked