Need to modify an NSMutableArray that is pre-loaded with data during fast enumeration in iOS

Question

I have an NSMutableArray that is holding a list of objects. What I am trying to do is iterate through this list of objects, and find the matching object for the I am trying to insert. Once I find the matching object, I then want to simply replace the object that is currently in the list with the one I am trying to insert. I am trying to do this using fast enumeration:

TestResult *result = [[TestResult alloc] init];
    [result setName:name];
    [result setScore:score];
    [result setDateStamp:date];


    for (TestResult *checkTest in [DataModel sharedInstance].testResultList) {

        NSInteger indx = [[DataModel sharedInstance].testResultList indexOfObjectPassingTest:^BOOL(TestResult *obj, NSUInteger idx, BOOL *stop) {
            return [obj.name isEqualToString:name];
        }];

        if (indx != NSNotFound) {

            [[DataModel sharedInstance].testResultList replaceObjectAtIndex:indx withObject:result];

        }

    }

Unfortunately, when I run the above code, I am getting the following error:

*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSArrayM: 0x9624820> was mutated while being enumerated.'

Can anyone see what I am doing wrong, and how can work around this, yet achieve the functionality that I described above?

score 4 · Accepted Answer · answered Dec 18 '12 at 20:14

4

First of all the crash is pretty self explanatory. You are actually mutating (aka. replacing an object in the array), while the fast enumeration is still in progress, which is not permitted.

The solution if you would go with your design would be to actually capture the index of the object, break the fast enumeration and replace the object outside the fast enumeration.

However what you are doing is not correct. The way to use the indexOfObjectPassingTest is this:

NSInteger indx = [[DataModel sharedInstance].testResultList indexOfObjectPassingTest:^BOOL(TestResult *obj, NSUInteger idx, BOOL *stop) {
    return [obj.name isEqualToString:name];
}];

if (indx != NSNotFound) {

    [[DataModel sharedInstance].testResultList replaceObjectAtIndex:indx withObject:result];

}

You don't need to manually enumerate through all elements of the array. The function does this for you internally.

answered Dec 18 '12 at 20:14

Lefteris

14,550
2
56
95

Thanks very much for show me how to do this. I feel even more ignorant than before :-) – syedfa Dec 18 '12 at 20:20
@Lefteris, +1. You are right. That enumeration was unnecessary. – iDev Dec 18 '12 at 20:20
@syedfa We all are still learning for more experienced developers. Asking is not bad and learning from your misatkes neither! – Lefteris Dec 18 '12 at 20:23
@ACB It captured my attention as I wondered why syedfa was doing this, that's why I spotted it immediately. – Lefteris Dec 18 '12 at 20:23
Thanks again Lefteris. Take care. – syedfa Dec 18 '12 at 20:29

iDev · Answer 2 · 2012-12-18T20:15:19.773

As the error message says, you cannot edit an array which is being enumerated. You need to have a different array and then you can do this.

The following would have worked,

TestResult *result = [[TestResult alloc] init];
[result setName:name];
[result setScore:score];
[result setDateStamp:date];

NSArray *array = [NSArray arrayWithArray:[DataModel sharedInstance].testResultList];    

for (TestResult *checkTest in array) {

    NSInteger indx = [[DataModel sharedInstance].testResultList indexOfObjectPassingTest:^BOOL(TestResult *obj, NSUInteger idx, BOOL *stop) {
        return [obj.name isEqualToString:name];
    }];

    if (indx != NSNotFound) {
        [[DataModel sharedInstance].testResultList replaceObjectAtIndex:indx withObject:result];
    }
}

Update: As per the comment from Lefteris, you dont need to iterate through the array if you are using indexOfObjectPassingTest method.

You can simply use,

TestResult *result = [[TestResult alloc] init];
[result setName:name];
[result setScore:score];
[result setDateStamp:date];

NSInteger indx = [[DataModel sharedInstance].testResultList indexOfObjectPassingTest:^BOOL(TestResult *obj, NSUInteger idx, BOOL *stop) {
    return [obj.name isEqualToString:name];
}];

if (indx != NSNotFound) {
    [[DataModel sharedInstance].testResultList replaceObjectAtIndex:indx withObject:result];
}

I'm surprised you are not spotting the obvious error, and do a fast enumeration on top of the indexOfObjectsPassing test NSArray method. — Lefteris, Dec 18 '12 at 20:16
@Lefteris, Yes, you are correct. I didnt actually think along the logic. I was more focused on the issue OP mentioned. — iDev, Dec 18 '12 at 20:17

score 0 · Answer 3 · answered Dec 18 '12 at 20:09

As the error message say you can't modify the array used in a foreach bucle. Change your code to this:

TestResult *result = [[TestResult alloc] init];
[result setName:name];
[result setScore:score];
[result setDateStamp:date];

NSInteger indx = NSNotFound;
for (TestResult *checkTest in [DataModel sharedInstance].testResultList) {

    indx = [[DataModel sharedInstance].testResultList indexOfObjectPassingTest:^BOOL(TestResult *obj, NSUInteger idx, BOOL *stop) {
        return [obj.name isEqualToString:name];
    }];
}
if (indx != NSNotFound) {
    [[DataModel sharedInstance].testResultList replaceObjectAtIndex:indx withObject:result];                            
}

score 0 · Answer 4 · answered Dec 18 '12 at 20:14

0

You cannot replace, delete or insert elements in an array while being enumerated. But you could change all the attributes of the element at idxn to the attributes of the result. This way the objects remain.

Hope this helps!

answered Dec 18 '12 at 20:14

Levi

7,313
2
32
44

Need to modify an NSMutableArray that is pre-loaded with data during fast enumeration in iOS

4 Answers4