Shorter way to write if else statement?

Question

<?php
  $typeface = $page->typeface();
    if($typeface == '') {
  } else {
      echo '<li><span>Typeface: </span>'.$typeface.'</li>';
  }
?>

I initially tried the PHP code below but it would still output the HTML:
<li><span>Typeface: </span></li> even if the string was empty.

<?php $typeface =  $page->typeface(); 
  if (!empty($typeface)): ?>
    <li><span>Typeface: </span><?php echo $typeface ?></li> 
  <?php endif; ?>

So my question is, how can I write the code at the very top in a shorter way?

mychalvlcek · Accepted Answer · 2012-12-08T09:39:59.493

3

$typeface = trim($page->typeface());
if($typeface != '')
    echo '<li><span>Typeface: </span>'.$typeface.'</li>';

EDIT: (removing new lines)

$typeface = trim(str_replace(array("\r", "\r\n", "\n"), '', $page->typeface()));
if($typeface != '')
    echo '<li><span>Typeface: </span>'.$typeface.'</li>';

edited Dec 08 '12 at 09:39

answered Dec 08 '12 at 09:09

mychalvlcek

3,956
1
19
34

I would apply a trim also just in case. – Peter Kiss Dec 08 '12 at 09:12
@PeterKiss What do you mean trim? I do have an empty line if the value is empty. How would I go about removing that? – Chris Burton Dec 08 '12 at 09:13
if(trim($page->typeface()) != '') { /* ... */ } – Peter Kiss Dec 08 '12 at 09:14
The trim still leaves a blank line. – Chris Burton Dec 08 '12 at 09:34
Really appreciate this @vlcekmi3 – Chris Burton Dec 08 '12 at 09:47

Bhuvan Rikka · Answer 2 · 2012-12-08T09:39:25.233

2

Try this

(isset($typeface) && !empty($typeface))?echo "<li><span>Typeface: </span>".$typeface."</li>":"";

edited Dec 08 '12 at 09:39

answered Dec 08 '12 at 09:16

Bhuvan Rikka

2,683
1
17
27

@ChristopherBurton Edited...Try now – Bhuvan Rikka Dec 08 '12 at 09:34
That works. I'm still having an issue with an empty line in view source, though. – Chris Burton Dec 08 '12 at 09:41

score 0 · Answer 3 · answered Dec 08 '12 at 09:19

0

($typeface=="")?echo "":echo '<li><span>Typeface: </span>'.$typeface.'</li>';

answered Dec 08 '12 at 09:19

harry

1,410
3
12
31

score 0 · Answer 4 · edited May 23 '17 at 12:32

0

Depending on the return type of $page->typeface() method, and the placement of the code (looks like you're on a template view), I might opt for:

<?php if ($typeface === $page->typeface()): ?>
    <li><span>Typeface: </span><?=$typeface?></li>
<?php endif; ?>

PHP docs here:

Alternative syntax for control structures

See here for cautions you should consider when using <?=...?> short tags.

An alternative to <?=...?> would be: <?php echo $typeface; ?>.

Hope that helps!

EDIT:

Actually, I second-guessed myself earlier (I blame sleep deprivation). I originally had this code (except for the trim()):

<?php if ($typeface = trim($page->typeface())): ?>
    <li><span>Typeface: </span><?=$typeface?></li>
<?php endif; ?>

Where I'm setting the variable $typeface in the if(). This technique should shorten your code by a line.

Here's a working example using simple strings:

<?php $foo = ""; ?>
...
<?php if ($typeface = trim($foo)): ?>
    <li><span>Typeface: </span><?=$typeface?></li>
<?php endif; ?>

... outputs: Nothing.

<?php $foo = 'I\'m a string!'; ?>
...
<?php if ($typeface = trim($foo)): ?>
    <li><span>Typeface: </span><?=$typeface?></li>
<?php endif; ?>

... outputs: <li><span>Typeface: </span>I'm a string!</li> (obviously, missing the opening and closing <ul></ul>.

edited May 23 '17 at 12:32

Community

1
1

answered Dec 08 '12 at 09:22

mhulse

4,062
6
28
35

For some reason that still outputs `
Typeface:

Chris Burton

Dec 08 '12 at 09:27

@ChristopherBurton When I first posted the code, I had `$typeface = $page->typeface()` (copy/paste error). I changed it to `$typeface === $page->typeface()` (note the `===`). Hopefully that's why it's not working for you? – mhulse Dec 08 '12 at 09:29

I still get the same result. – Chris Burton Dec 08 '12 at 09:31

Gosh, I'd hate to waste your time... You might trim, like the others are saying: ``? When I test using these vars: ``, where `$foo` is my version of `$page->typeface()`, it works for me... What does $page->typeface() expected return type/value? I assume it's an empty/non-empty string return? Again, I don't mean to waste your time (looks like you're getting a ton of great answers already). :) – mhulse Dec 08 '12 at 09:41

@ChristopherBurton Even though you've got your answer, I've updated my answer... My original thinking stands (see my **EDIT** above). I **sometimes** like assigning vars in an `if()` check... Makes for on less line of code to juggle. If that does not work, then you might need to apply a more hardcore trim like the one used in the [solution above](http://stackoverflow.com/a/13776080/922323). Happy coding! – mhulse Dec 08 '12 at 11:15

score 0 · Answer 5 · answered Dec 08 '12 at 09:37

0

Try This..

$typeface = $page->typeface();
echo $res=($typeface != '')?'<li><span>Typeface: </span>'.$typeface.'</li>':'';

answered Dec 08 '12 at 09:37

Mrinmoy Ghoshal

2,804
1
19
17

Shorter way to write if else statement?

5 Answers5

EDIT: